Merged
Conversation
ghost
requested review from
waynew
previously approved these changes
Sep 10, 2020
Contributor
waynew
left a comment
waynew
left a comment
There was a problem hiding this comment.
Seems reasonable to me.
This doesn't seem like something that needs tests - I'll pass it by the team and see what they think!
DmitryKuzmenko
previously approved these changes
Sep 11, 2020
Contributor
|
Agree with @waynew |
dwoz
added
the
needs-testcase
major0
force-pushed
the
fix/salt_cloud_ec2_list_availability_zones
branch
from
2f2f6a7 to
effc8b0
Compare
DmitryKuzmenko
previously approved these changes
Sep 28, 2020
major0
force-pushed
the
fix/salt_cloud_ec2_list_availability_zones
branch
from
effc8b0 to
9e5e40d
Compare
The `list_availability_zones()` function was made private in the salt-cloud ec2 driver in response to saltstack#15515 It is not clear why this function was made private in response to this bug report. This function is listed as publicly available in the salt-cloud feature matrix: https://docs.saltstack.com/en/latest/topics/cloud/features.html This function also exists publicly in aliyun and tencentcloud drivers. Further more, the tencentcloud usage is documented in the `salt(7)` manpage. This reverts commit 38c9583. This commit fixes saltstack#58421
major0
force-pushed
the
fix/salt_cloud_ec2_list_availability_zones
branch
from
9e5e40d to
9096a25
Compare
DmitryKuzmenko
approved these changes
Oct 6, 2020
DmitryKuzmenko
removed
the
needs-testcase
Contributor
|
@dwoz this doesn't need a test case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
list_availability_zones()function was made private in the salt-cloud ec2 driver in response to #15515It is not clear why this function was made private in response to this
bug report.
This function is listed as publicly available in the salt-cloud feature
matrix: https://docs.saltstack.com/en/latest/topics/cloud/features.html
This function also exists publicly in aliyun and tencentcloud drivers.
Further more, the tencentcloud usage is documented in the
salt(7)man page.
This reverts commit 38c9583.
This commit fixes #58421
What does this PR do?
Reverts 38c9583
What issues does this PR fix or reference?
Fixes: #58421
Relates to #15515
Previous Behavior
salt-cloud ec2 driver's
list_availability_zones()was private.New Behavior
Makes salt-cloud ec2 driver's
list_availability_zones()was public.Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
No