Skip to content

Add verify_ssl to file.managed state #58451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 25, 2020
Merged

Add verify_ssl to file.managed state #58451

merged 3 commits into from
Sep 25, 2020

Conversation

Ch3LL
Copy link
Contributor

@Ch3LL Ch3LL commented Sep 14, 2020

What does this PR do?

adds new option to file modules - verify_ssl. This adds the ability to skip validation check of an SSL certificate for https sources and source_hash.

What issues does this PR fix or reference?

Fixes: #52663

Previous Behavior

Could not skip ssl certification validation check

New Behavior

can use new option verify_ssl for the file states/execution modules to skip SSL certificate check.

Merge requirements satisfied?

Commits signed with GPG?

Yes

@Ch3LL Ch3LL requested a review from a team as a code owner September 14, 2020 11:26
@ghost ghost requested review from DmitryKuzmenko and removed request for a team September 14, 2020 11:27
DmitryKuzmenko
DmitryKuzmenko previously approved these changes Sep 14, 2020
@sagetherage sagetherage added the Magnesium Mg release after Na prior to Al label Sep 14, 2020
@sagetherage sagetherage added the ZD The issue is related to a Zendesk customer support ticket. label Sep 16, 2020
@dwoz dwoz added the Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases label Sep 22, 2020
@Ch3LL Ch3LL removed the Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases label Sep 25, 2020
@dwoz dwoz merged commit 98ba07a into saltstack:master Sep 25, 2020
"",
"True",
"verify_ssl={}".format(verify_ssl),
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI,
If you pass these as keyword arguments to run() you would likely not need all of the "", in the call.

ret = salt_call_cli.run(
    "--local",
    "file.get_managed",
    tmpdir.join("test_managed.txt").strpath,
   saltenv="base"

Bah!
Nevermind, it's all arguments to the function, not keyword arguments.
Bad code, bad bad code....
Anyway, you can still do .run(... args..., verify_ssl=True) , no need to pass verify_ssl=True as a string argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Magnesium Mg release after Na prior to Al ZD The issue is related to a Zendesk customer support ticket.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: file.managed verify_ssl option.
5 participants