Add verify_ssl to file.managed state #58451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
DmitryKuzmenko
previously approved these changes
Sep 14, 2020
sagetherage
added
the
ZD
dwoz
added
the
Needs-Testcase
Ch3LL
removed
the
Needs-Testcase
dwoz
approved these changes
Sep 25, 2020
s0undt3ch
reviewed
Sep 26, 2020
| "", | ||
| "True", | ||
| "verify_ssl={}".format(verify_ssl), | ||
| ) |
There was a problem hiding this comment.
FYI,
If you pass these as keyword arguments to run() you would likely not need all of the "", in the call.
ret = salt_call_cli.run(
"--local",
"file.get_managed",
tmpdir.join("test_managed.txt").strpath,
saltenv="base"
Bah!
Nevermind, it's all arguments to the function, not keyword arguments.
Bad code, bad bad code....
Anyway, you can still do .run(... args..., verify_ssl=True) , no need to pass verify_ssl=True as a string argument.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
What does this PR do?
adds new option to file modules -
verify_ssl. This adds the ability to skip validation check of an SSL certificate for https sources and source_hash.What issues does this PR fix or reference?
Fixes: #52663
Previous Behavior
Could not skip ssl certification validation check
New Behavior
can use new option
verify_sslfor the file states/execution modules to skip SSL certificate check.Merge requirements satisfied?
Commits signed with GPG?
Yes