Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules/nilrt_ip.py: Make DNS optional in set_static_all #58479

Merged
merged 5 commits into from Oct 2, 2020

Conversation

chotea
Copy link
Contributor

@chotea chotea commented Sep 17, 2020

Make dns optional in set_static_all

No tests for non-"nilrt" use case since we will support only
this distribution. A cleanup is needed here but it will
be addressed in a later PR

This change is part of our plan to upstream the changes from the NI salt repo
https://github.com/ni/salt/tree/ni/master/2018.3/salt

Signed-off-by: Cristian Hotea cristian.hotea@ni.com

No tests for non-"nilrt" use case since we will support only
this distribution. A cleanup is needed here but it will
be addressed in a later PR

Signed-off-by: Cristian Hotea <cristian.hotea@ni.com>
@chotea chotea requested a review from a team as a code owner September 17, 2020 11:52
@ghost ghost requested review from DmitryKuzmenko and removed request for a team September 17, 2020 11:52
andzn
andzn previously approved these changes Sep 17, 2020
@chotea
Copy link
Contributor Author

chotea commented Sep 17, 2020

Files got "blacked" so to help the reviewers here is the only behavioral change:
"set_static_all" function + added tests

DmitryKuzmenko
DmitryKuzmenko previously approved these changes Sep 18, 2020
@DmitryKuzmenko
Copy link
Contributor

re-run archlts
re-run windows

twangboy
twangboy previously approved these changes Sep 18, 2020
@twangboy twangboy self-assigned this Sep 18, 2020
@twangboy twangboy added the Magnesium Mg release after Na prior to Al label Sep 18, 2020
@twangboy twangboy added this to the Magnesium milestone Sep 18, 2020
@dwoz
Copy link
Contributor

dwoz commented Oct 1, 2020

re-run windows

dwoz
dwoz approved these changes Oct 2, 2020
@dwoz dwoz merged commit ca51161 into saltstack:master Oct 2, 2020
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Magnesium Mg release after Na prior to Al
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants