modules/nilrt_ip.py: Make DNS optional in set_static_all #58479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No tests for non-"nilrt" use case since we will support only this distribution. A cleanup is needed here but it will be addressed in a later PR Signed-off-by: Cristian Hotea <cristian.hotea@ni.com>
ghost
requested review from
andzn
previously approved these changes
Sep 17, 2020
|
Files got "blacked" so to help the reviewers here is the only behavioral change: |
DmitryKuzmenko
previously approved these changes
Sep 18, 2020
|
re-run archlts |
twangboy
previously approved these changes
Sep 18, 2020
garethgreenaway
dismissed stale reviews from twangboy, DmitryKuzmenko, and andzn
via
20f3139
|
re-run windows |
dwoz
approved these changes
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Make dns optional in set_static_all
No tests for non-"nilrt" use case since we will support only
this distribution. A cleanup is needed here but it will
be addressed in a later PR
This change is part of our plan to upstream the changes from the NI salt repo
https://github.com/ni/salt/tree/ni/master/2018.3/salt
Signed-off-by: Cristian Hotea cristian.hotea@ni.com