On macOS check if git is a stub or not before importing gitpython. #58581
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
On a freshly installed macOS, accessing
git
triggers a GUI dialog prompting users to install the Developer Command Line Tools. This is a nuisance for users, and since Salt really only cares about whethergit
is present, if we can find another way... Well we did!On macOS, first we do a
which git
. If thegit
we get back is the "standard" location, we then use the stockxcode-select -p
command, to determine whether the Developer tools are installed. If they aren't, thisgit
is actually a stub and will trigger the dialog.What issues does this PR fix or reference?
Fixes: #58575
Previous Behavior
See issue; every Salt run, the gitfs module triggers the GUI dialog.
New Behavior
On macOS without the Developer Command Line Tools, no dialogs are shown.
Merge requirements satisfied?
Commits signed with GPG?
Yes