Features/vault enterprise

[eadderley-tc]

What does this PR do?

This PR enables Salt to communicate with an Enterprise Vault via X-Vault-Namespace headers.

What issues does this PR fix or reference?

Fixes: 58585

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

• Docs
• Changelog - https://docs.saltstack.com/en/master/topics/development/changelog.html
• Tests written/updated

Not entirely sure how to write tests for this, as the headers don't break anything if no namespace is supplied and Vault doesn't complain if namespaces aren't enabled.

Commits signed with GPG?

No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

[welcome]

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

• Community Wiki
• Salt’s Contributor Guide
• Join our Community Slack
• IRC on Freenode
• SaltStack YouTube channel
• SaltStackInc Twitch channel

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at core@saltstack.com or reach out directly to the Community Manager, Cassandra Faris via Slack. We’re glad you’ve joined our community and look forward to doing awesome things with you!

[DmitryKuzmenko]

@eadderley-tc thank you for PR. I've put some comments to my review.
Also about tests: in this case it's needed to add or update the existing tests to cover your changes. I.e. check that the code works as expected in all the cases you've added: there's no namespace specified, there's a namespace specified, exception cases.

[eadderley-tc]

@DmitryKuzmenko We've added some tests and cleaned up the linting. Sorry about the delay, got pulled off for project work and illness. Can you explain what's going wrong in that ci/pre-commit?

[sagetherage]

@dwoz or @s0undt3ch can you review this PR please? @eadderley-tc Dmitry is unfortunately no longer on the project, but looking to get this reviewed. Pre-commit can be pain, if it is helpful please attend or get with @waynew on IRC, Community Slack or at the Test Clinics we hold on Tue/Thu via Twitch.

[s0undt3ch]

Please remove the changes under doc/man those get generated automatically.

And there's also conflicts that need to be solved.

[eadderley-tc]

Please remove the changes under doc/man those get generated automatically.

What do they get automatically generated from?

[vveliev-tc]

@s0undt3ch not sure why some tests are failing, what is currently outstanding for this PR?

[vveliev-tc]

re-run centos7-py3-pycryptodome-pytest

[s0undt3ch]

Can you please rebase against the latest master branch changes? Thanks!

[vveliev-tc]

re-run windows2016-py3-pytest

[vveliev-tc]

re-run windows2019-py3-pytest

[vveliev-tc]

s0undt3ch - is there anything we should do about failing tests?

[eadderley-tc]

@s0undt3ch As far as we can tell (asked on the Slack too) the remaining failing tests are broken. Can we get another review?

[eadderley-tc]

@s0undt3ch Latest master commits merged in

[eadderley-tc]

@s0undt3ch What are out next steps here? Eager to get this merged.

[Ch3LL]

Looks like there is a just one last lint failure, probably caused by my suggestion. Apologies on that.

[welcome]

Congratulations on your first PR being merged! 🎉