New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Features/chocolatey source added state #58590
Features/chocolatey source added state #58590
Conversation
list_sources allows to list respo's name, source location, user and status (enable - disable).
Allows to add sources in a state
Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Thanks for the PR. One requested change.
…Guimbert/salt into features/chocolatey-source-added-state
Congratulations on your first PR being merged! |
Observation: Seems like it lacks the option to set priority for each source, which is pretty important. Also in the patch notes for 3002, this state function was reported to be source_added but it's actually source_present. |
What does this PR do?
Add the
source_added
function for the Chocolatey state that match theadd_source
abilities of the Chocolatey module. This add a way to use custom Chocolatey repository with authentication. To match the behavior of theinstalled
function, I also added the functionlist_sources
in the module.What issues does this PR fix or reference?
Fixes: #58588
Merge requirements satisfied?
Is the doc from the functions enough?
Commits signed with GPG?
No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.