Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/chocolatey source added state #58590

Merged

Conversation

TGuimbert
Copy link
Contributor

@TGuimbert TGuimbert commented Sep 30, 2020

What does this PR do?

Add the source_added function for the Chocolatey state that match the add_source abilities of the Chocolatey module. This add a way to use custom Chocolatey repository with authentication. To match the behavior of the installed function, I also added the function list_sources in the module.

What issues does this PR fix or reference?

Fixes: #58588

Merge requirements satisfied?

Is the doc from the functions enough?

Commits signed with GPG?

No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

list_sources allows to list respo's name, source location, user and status (enable - disable).
Allows to add sources in a state
@welcome
Copy link

welcome bot commented Sep 30, 2020

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at core@saltstack.com or reach out directly to the Community Manager, Cassandra Faris via Slack. We’re glad you’ve joined our community and look forward to doing awesome things with you!

@TGuimbert TGuimbert marked this pull request as ready for review September 30, 2020 15:05
@TGuimbert TGuimbert requested a review from a team as a code owner September 30, 2020 15:05
@TGuimbert TGuimbert requested review from Akm0d and removed request for a team September 30, 2020 15:05
@ghost ghost requested a review from krionbsd September 30, 2020 15:05
ArthurREGNARD
ArthurREGNARD previously approved these changes Oct 2, 2020
Copy link
Contributor

@twangboy twangboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Thanks for the PR. One requested change.

salt/states/chocolatey.py Outdated Show resolved Hide resolved
@twangboy twangboy added the Magnesium Mg release after Na prior to Al label Oct 2, 2020
@twangboy twangboy self-assigned this Oct 2, 2020
@dwoz dwoz merged commit f1a269b into saltstack:master Oct 5, 2020
26 checks passed
@welcome
Copy link

welcome bot commented Oct 5, 2020

Congratulations on your first PR being merged! 🎉

@TGuimbert TGuimbert deleted the features/chocolatey-source-added-state branch October 6, 2020 07:41
@Slemaire-PNI
Copy link

Observation: Seems like it lacks the option to set priority for each source, which is pretty important. Also in the patch notes for 3002, this state function was reported to be source_added but it's actually source_present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Magnesium Mg release after Na prior to Al
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Add a way to use Chocolatey repositories with authentication
5 participants