zabbix_host.present: many fixes #58604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piterpunk
requested review from
garethgreenaway
and removed request for
a team
ghost
requested a review
from
piterpunk
changed the title
Author
|
Converted to Work-In-Progress, I will include the fix for #53838 to keep the state 100% Ok with the documentation. |
piterpunk
force-pushed
the
zabbix_host_present_many_fixes
branch
from
6e522fa to
4a691b8
Compare
OrangeDog
suggested changes
Oct 8, 2020
piterpunk
force-pushed
the
zabbix_host_present_many_fixes
branch
from
4a691b8 to
29b5cd3
Compare
piterpunk
changed the title
piterpunk
force-pushed
the
zabbix_host_present_many_fixes
branch
from
4c4b982 to
9f43e5b
Compare
Author
|
I fixed the last failing tests today and will be great to have this approved before began to test and adjust the other Zabbix related states for Zabbix 5+ |
garethgreenaway
previously approved these changes
Jan 14, 2021
twangboy
requested changes
Feb 10, 2021
added 7 commits
February 11, 2021 01:03
- Added visible_name to be pass to zabbix module. It was on documentation but the argument was not sent to underlying module. - Added checks before "pop" the elements "bulk" and "details" from hostinterfaces_get's response. Without that, the interface comparison didn't works with Zabbix >= 5.0 - Fixed the "inventory" comparison. It failed when there isn't a current and a new inventory. - Major rewrite of the update_interfaces routine. - Adequation to the new lint, black, isort, requirements.
- Now the zabbix_host.present accepts all host properties allowing to change the inventory mode or add a description to the created host. - Pass the "details" mandatory parameter to create SNMP hostinterfaces. The lack of this parameter prevents the host creation when any of its interfaces are SNMP.
piterpunk
force-pushed
the
zabbix_host_present_many_fixes
branch
from
9f43e5b to
6741403
Compare
twangboy
requested changes
Feb 11, 2021
twangboy
approved these changes
Feb 11, 2021
Author
|
@sagetherage to me it's important to have this PR merged before the code-freeze, I am using it at other projects and give maintenance to out-of-tree code isn't good. |
Contributor
|
@piterpunk we have it marked for |
garethgreenaway
approved these changes
Feb 19, 2021
Ch3LL
approved these changes
Feb 22, 2021
This was referenced Mar 23, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes allows zabbix_host.present to:
What issues does this PR fix or reference?
Fixes #58602
Fixes #58603
Fixes #53838
Fixes #58620
Previous Behavior
Host's "Visible Name" never was configured because zabbix_host.present didn't pass the parameter visible_name to zabbix.create_host. Other additional host properties were also ignored.
Host comparison and update fails because non existent key "bulk" and a failure in inventory check.
The update_interfaces didn't really update them, it try to removes and recreates them. Usually this strategy fails, as interfaces with linked items can't be removed. Also, no SNMP interface can be created in Zabbix 5.0
New Behavior
Host's "Visible Name" is configured and additional host properties are processed. Host comparison and update runs Ok.
The update_interfaces now try to match the interface types and update them in place, then create the new ones and remove the rest.
SNMP interfaces can be created and updated seamlessly.
Merge requirements satisfied?
Commits signed with GPG?
No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.