[DOCS]: Add topic describing Salt System Architecture for newbies - #58664
Merged
Conversation
barbaricyawps
requested review from
ScriptAutomate,
garethgreenaway and
twangboy
October 7, 2020 17:21
added 2 commits
October 7, 2020 14:04
dwoz
previously approved these changes
Oct 8, 2020
sagetherage
approved these changes
Nov 13, 2020
added 2 commits
December 10, 2020 10:55
ScriptAutomate
approved these changes
Dec 10, 2020
ScriptAutomate
left a comment
Contributor
There was a problem hiding this comment.
This looks great to me. The broken tests are unrelated, though.
Can we get final review and sign-off by @dwoz and @garethgreenaway ? And then override the passing tests requirements? I've pulled locally and built, and it looks fine.
git fetch upstream pull/58664/head:pr58664
git checkout pr58664
# Passes nox docs build
nox -e 'docs-html(compress=False, clean=True)'
# Renders great
firefox doc/_build/html/topics/salt_system_architecture.html
It also is tagged for easy reference from other docs in the repo, and appears toward the top in the index / TOC.
garethgreenaway
approved these changes
Dec 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR is a docs-only change that includes two changes:
What issues does this PR fix or reference?
Fixes:
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes? I think?
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.