Skip to content

states.saltmod: Handle roster in salt.function state - #58679

Merged
Ch3LL merged 2 commits into
saltstack:masterfrom
TeddyAndrieux:salt_function_roster
Oct 21, 2021
Merged

states.saltmod: Handle roster in salt.function state#58679
Ch3LL merged 2 commits into
saltstack:masterfrom
TeddyAndrieux:salt_function_roster

Conversation

@TeddyAndrieux

@TeddyAndrieux TeddyAndrieux commented Oct 8, 2020

Copy link
Copy Markdown
Contributor

What does this PR do?

The salt states salt.function handle roster as the salt.states
states does

What issues does this PR fix or reference?

Fixes: #58662

Commits signed with GPG?

No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@TeddyAndrieux
TeddyAndrieux requested a review from a team as a code owner October 8, 2020 13:25
@TeddyAndrieux
TeddyAndrieux requested review from cmcmarrow and removed request for a team October 8, 2020 13:25
@welcome

welcome Bot commented Oct 8, 2020

Copy link
Copy Markdown

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at core@saltstack.com or reach out directly to the Community Manager, Cassandra Faris via Slack. We’re glad you’ve joined our community and look forward to doing awesome things with you!

@ghost
ghost requested a review from Ch3LL October 8, 2020 13:25
Ch3LL
Ch3LL previously approved these changes Oct 8, 2020
View reviewed changes
@Ch3LL

Ch3LL commented Oct 8, 2020

Copy link
Copy Markdown
Contributor

@TeddyAndrieux looks like there is a failure that needs to be fixed.

@TeddyAndrieux

TeddyAndrieux commented Oct 8, 2020

Copy link
Copy Markdown
Contributor Author

@TeddyAndrieux looks like there is a failure that needs to be fixed.

Right, sorry, it's fixed

@TeddyAndrieux
TeddyAndrieux force-pushed the salt_function_roster branch 2 times, most recently from 7743c3c to 264fb95 Compare October 8, 2020 15:13
Ch3LL
Ch3LL previously approved these changes Oct 8, 2020
View reviewed changes
cmcmarrow
cmcmarrow previously approved these changes Oct 15, 2020
View reviewed changes
@cmcmarrow

cmcmarrow commented Oct 15, 2020

Copy link
Copy Markdown
Contributor

@TeddyAndrieux Welcome to the Salt Community!

@TeddyAndrieux
TeddyAndrieux dismissed stale reviews from cmcmarrow and Ch3LL via b87a9f3 July 6, 2021 11:08
@TeddyAndrieux
TeddyAndrieux force-pushed the salt_function_roster branch 3 times, most recently from c6c811e to 309c547 Compare July 6, 2021 11:28
@TeddyAndrieux
TeddyAndrieux requested review from Ch3LL and cmcmarrow July 6, 2021 14:51
Ch3LL
Ch3LL previously approved these changes Oct 12, 2021
View reviewed changes
TeddyAndrieux and others added 2 commits October 14, 2021 14:15
@TeddyAndrieux
states.saltmod: Handle roster in salt.function state
e86e202 
The salt states `salt.function` handle `roster` as the `salt.states`
states does

Fixes: saltstack#58662
Signed-off-by: Teddy Andrieux <teddy.andrieux@scality.com>
Megan Wilhite @TeddyAndrieux
Add changelog and versionadded note
c012912
@TeddyAndrieux
TeddyAndrieux requested a review from Ch3LL October 14, 2021 12:15
@TeddyAndrieux

TeddyAndrieux commented Oct 15, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@Ch3LL thank you for the approval (+ changelog)
Do I need to do anything specific to merge this PR ?

@Ch3LL
Ch3LL merged commit fae4c6e into saltstack:master Oct 21, 2021
@welcome

welcome Bot commented Oct 21, 2021

Copy link
Copy Markdown

Congratulations on your first PR being merged! 🎉

@TeddyAndrieux
TeddyAndrieux deleted the salt_function_roster branch October 21, 2021 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmcmarrow cmcmarrow Awaiting requested review from cmcmarrow
1 more reviewer
@Ch3LL Ch3LL Ch3LL approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] State salt.function do not support roster

3 participants

@TeddyAndrieux @Ch3LL @cmcmarrow