Closed
Conversation
ghost
requested a review
from 
major0
force-pushed
the
fix/enable_boto_unit_tests
branch
3 times, most recently
from
6980a89 to
8213942
Compare
major0
force-pushed
the
fix/enable_boto_unit_tests
branch
4 times, most recently
from
f0b41fe to
3b2eba2
Compare
- Enable a number of boto tests that were previously disabled due to getmoto/moto#493 - Enble boto_vpc state tests previously disabled due to getmoto/moto#1706 These issues was resolved and these tests appear to work as expected. fixes saltstack#58771
Remove invalid tests against `boto_vpc.associate_new_dhcp_options_to_vpc()` and `boto_vpc.associate_new_network_acl_to_subnet()`. These methods were removed in commit ad5830e related to issue saltstack#58771
major0
force-pushed
the
fix/enable_boto_unit_tests
branch
from
3b2eba2 to
ff55a52
Compare
waynew
approved these changes
Oct 22, 2020
Contributor
waynew
left a comment
waynew
left a comment
There was a problem hiding this comment.
🚀 nice find! 👍 for enabled tests 🖤
twangboy
requested changes
Oct 27, 2022
Contributor
|
Closing this due to inactivity. Anyone should feel free to re-open it if they want to see it through to the end in one release cycle. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes
Fixes #58771
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes