Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/enable boto unit tests #58709

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

major0
Copy link
Collaborator

@major0 major0 commented Oct 10, 2020

What does this PR do?

Fixes

Fixes #58771

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

@major0 major0 requested a review from a team as a code owner October 10, 2020 13:48
@major0 major0 requested review from twangboy and removed request for a team October 10, 2020 13:48
@ghost ghost requested a review from waynew October 10, 2020 13:48
@major0 major0 force-pushed the fix/enable_boto_unit_tests branch 3 times, most recently from 6980a89 to 8213942 Compare October 12, 2020 14:17
@major0 major0 mentioned this pull request Oct 13, 2020
3 tasks
@major0 major0 force-pushed the fix/enable_boto_unit_tests branch 4 times, most recently from f0b41fe to 3b2eba2 Compare October 20, 2020 19:57
- Enable a number of boto tests that were previously disabled due to
  getmoto/moto#493

- Enble boto_vpc state tests previously disabled due to
  getmoto/moto#1706

These issues was resolved and these tests appear to work as expected.

fixes saltstack#58771
Remove invalid tests against
`boto_vpc.associate_new_dhcp_options_to_vpc()` and
`boto_vpc.associate_new_network_acl_to_subnet()`. These methods were
removed in commit ad5830e

related to issue saltstack#58771
waynew
waynew approved these changes Oct 22, 2020
Copy link
Contributor

@waynew waynew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 nice find! 👍 for enabled tests 🖤

@sagetherage sagetherage added Tests boto AWS wrapper modules labels May 12, 2021
Copy link
Contributor

@twangboy twangboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be rebased... and the tests moved to pytest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
boto AWS wrapper modules Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TESTS] Enable disabled boto tests
4 participants