feat: add unit test for utils/boto3mod#58713
Merged
Ch3LL merged 2 commits intosaltstack:masterfrom May 5, 2021
Merged
Conversation
ghost
requested a review
from 
major0
force-pushed
the
feat/boto3mod_unit_tests
branch
from
cb8ef26 to
592f240
Compare
cmcmarrow
previously approved these changes
Oct 15, 2020
Ch3LL
suggested changes
Oct 20, 2020
major0
force-pushed
the
feat/boto3mod_unit_tests
branch
2 times, most recently
from
4eebfb5 to
08ffc76
Compare
Ch3LL
suggested changes
Oct 21, 2020
This module did not previously have any unit tests defined.
major0
force-pushed
the
feat/boto3mod_unit_tests
branch
from
624adee to
521f811
Compare
Ch3LL
approved these changes
Oct 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously
salt.utils.boto3moddid not have any unit tests for basic functionality defined.What does this PR do?
Add some basic unit testing for
salt.utils.boto3mod.Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes