wip: refactor boto_sns to use boto3#58723
Closed
major0 wants to merge 3 commits intosaltstack:masterfrom
Closed
Conversation
major0
force-pushed
the
feat/boto3_refactor_sns
branch
from
f38f07b to
3a49d05
Compare
ghost
requested a review
from
major0
force-pushed
the
feat/boto3_refactor_sns
branch
5 times, most recently
from
49c9bd6 to
b921e74
Compare
* Refactor the boto_sns module to use boto3 instead of boto2. * Add unit testing for boto_sns module.
major0
force-pushed
the
feat/boto3_refactor_sns
branch
from
b921e74 to
f021b50
Compare
major0
changed the title
Contributor
|
Closing this due to inactivity. Anyone should feel free to re-open it if they want to see it through to the end in one release cycle. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Previous Behavior
Previously
salt.modules.boto_snsused the deprecated AWS boto2 interface and had no test cases.New Behavior
Uses boto3 and has test cases.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes