Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: refactor boto_sns to use boto3 #58723

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

major0
Copy link
Collaborator

@major0 major0 commented Oct 13, 2020

What does this PR do?

  • Refactor the boto_sns module to use boto3 instead of boto2.
  • Add unit testing for boto_sns module.

Previous Behavior

Previously salt.modules.boto_sns used the deprecated AWS boto2 interface and had no test cases.

New Behavior

Uses boto3 and has test cases.

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

@major0 major0 requested a review from a team as a code owner October 13, 2020 14:29
@major0 major0 requested review from dwoz and removed request for a team October 13, 2020 14:29
@ghost ghost requested a review from DmitryKuzmenko October 13, 2020 14:36
@major0 major0 force-pushed the feat/boto3_refactor_sns branch 5 times, most recently from 49c9bd6 to b921e74 Compare October 20, 2020 15:20
* Refactor the boto_sns module to use boto3 instead of boto2.
* Add unit testing for boto_sns module.
@major0 major0 changed the title fix: refactor boto_sns to use boto3 wip: refactor boto_sns to use boto3 Oct 23, 2020
@sagetherage sagetherage removed the request for review from DmitryKuzmenko November 18, 2020 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants