Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#58747: Request addition of --addtag #58748

Merged
merged 6 commits into from
Feb 9, 2021
Merged

Conversation

me-coder
Copy link
Contributor

#58747: Request addition of --addtag as valid kwarg to linux_lvm module
What does this PR do?

Addresses #58747
What issues does this PR fix or reference?

Fixes: added new valid argument to vgcreate method of salt module: linux_lvm
Previous Behavior

The support for --addtag was missing.
New Behavior

The vgcreate method would support valid --addtag argument.
Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Docs
Changelog - https://docs.saltstack.com/en/master/topics/development/changelog.html

Tests written/updated

Commits signed with GPG?

No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@me-coder me-coder requested a review from a team as a code owner October 16, 2020 18:43
@me-coder me-coder requested review from dwoz and removed request for a team October 16, 2020 18:43
@welcome
Copy link

welcome bot commented Oct 16, 2020

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at core@saltstack.com. We’re glad you’ve joined our community and look forward to doing awesome things with you!

@ghost ghost requested a review from waynew October 16, 2020 18:43
@waynew
Copy link
Contributor

waynew commented Oct 22, 2020

Hey @me-coder thanks for the PR!

I've been OOO for a bit and am just catching up, apologies for the wait! I'll be reviewing this PR as soon as I can, thanks for your patience!

Copy link
Contributor

@waynew waynew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! This definitely needs a changelog entry entry, at least.

I have checked the manpage for vgcreate and verified that addtag is valid option. I wonder if we should go ahead and add other options, though 🤔

@me-coder
Copy link
Contributor Author

me-coder commented Dec 2, 2020

Thanks for the PR! This definitely needs a changelog entry entry, at least.

I have checked the manpage for vgcreate and verified that addtag is valid option. I wonder if we should go ahead and add other options, though 🤔

Hello @waynew,
I've been occupied with my present project, so sorry for the delay in reply.
I'll make those changes for the changelog entry

I've not considered the other parameters, viz.:

  1. --alloc
  2. --autobackup
  3. --metadatatype
  4. --zero

Reason for that being my lack of expertise in that area and not able to test these. I've tested -addtag to work as it was required in my existing engagement.

Let me know how you typically handle such situations and I'll be happy to help.

Ref: https://man7.org/linux/man-pages/man8/vgcreate.8.html

@me-coder me-coder force-pushed the master branch 2 times, most recently from decb110 to bc54744 Compare December 7, 2020 10:55
@me-coder
Copy link
Contributor Author

me-coder commented Dec 7, 2020

@waynew
I've updated the changelog and updated the missed parameters.
Kindly reconsider this PR.

Also, I would appreciate some help with the failed CI tasks/stages.

me-coder and others added 2 commits December 9, 2020 13:16
saltstack#58747: Request addition of --addtag as valid kwarg to linux_lvm module

Signed-off-by: Yashodhan Pise <yashodhan.pise@seagate.com>
Signed-off-by: Yashodhan Pise <yashodhan.pise@seagate.com>
Signed-off-by: Yashodhan Pise <yashodhan.pise@seagate.com>
Copy link
Contributor

@waynew waynew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typically we would require tests, but here you're not actually adding any behavior, just entries to a list of valid entries. I've verified that these are valid options, so aside from a test that makes a VM and tries these commands I can't really think of a useful way to test. There's assert these_values == other_values, but that's not very meaningful.

@waynew
Copy link
Contributor

waynew commented Dec 17, 2020

I'm not sure what's up with that pycryptodome failure, though...

@waynew
Copy link
Contributor

waynew commented Dec 17, 2020

re-run ubuntu1604-py3-pycryptodome-pytest

@Ch3LL Ch3LL merged commit f682171 into saltstack:master Feb 9, 2021
@welcome
Copy link

welcome bot commented Feb 9, 2021

Congratulations on your first PR being merged! 🎉

@sagetherage sagetherage added the Aluminium Release Post Mg and Pre Si label Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Aluminium Release Post Mg and Pre Si
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants