#58747: Request addition of --addtag

[me-coder]

#58747: Request addition of --addtag as valid kwarg to linux_lvm module
What does this PR do?

Addresses #58747
What issues does this PR fix or reference?

Fixes: added new valid argument to vgcreate method of salt module: linux_lvm
Previous Behavior

The support for --addtag was missing.
New Behavior

The vgcreate method would support valid --addtag argument.
Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Docs
Changelog - https://docs.saltstack.com/en/master/topics/development/changelog.html

Tests written/updated

Commits signed with GPG?

No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

[welcome]

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

• Community Wiki
• Salt’s Contributor Guide
• Join our Community Slack
• IRC on Freenode
• SaltStack YouTube channel
• SaltStackInc Twitch channel

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at core@saltstack.com. We’re glad you’ve joined our community and look forward to doing awesome things with you!

[waynew]

Hey @me-coder thanks for the PR!

I've been OOO for a bit and am just catching up, apologies for the wait! I'll be reviewing this PR as soon as I can, thanks for your patience!

[waynew]

Thanks for the PR! This definitely needs a changelog entry entry, at least.

I have checked the manpage for vgcreate and verified that addtag is valid option. I wonder if we should go ahead and add other options, though 🤔

[me-coder]

Thanks for the PR! This definitely needs a changelog entry entry, at least.

I have checked the manpage for vgcreate and verified that addtag is valid option. I wonder if we should go ahead and add other options, though 🤔

Hello @waynew,
I've been occupied with my present project, so sorry for the delay in reply.
I'll make those changes for the changelog entry

I've not considered the other parameters, viz.:

1. --alloc
2. --autobackup
3. --metadatatype
4. --zero

Reason for that being my lack of expertise in that area and not able to test these. I've tested -addtag to work as it was required in my existing engagement.

Let me know how you typically handle such situations and I'll be happy to help.

Ref: https://man7.org/linux/man-pages/man8/vgcreate.8.html

[me-coder]

@waynew
I've updated the changelog and updated the missed parameters.
Kindly reconsider this PR.

Also, I would appreciate some help with the failed CI tasks/stages.

[waynew]

Typically we would require tests, but here you're not actually adding any behavior, just entries to a list of valid entries. I've verified that these are valid options, so aside from a test that makes a VM and tries these commands I can't really think of a useful way to test. There's assert these_values == other_values, but that's not very meaningful.

[waynew]

I'm not sure what's up with that pycryptodome failure, though...

[waynew]

re-run ubuntu1604-py3-pycryptodome-pytest

[welcome]

Congratulations on your first PR being merged! 🎉