Fixing an issue preventing using pillar.get against integer pillar keys - #58750
Merged
Ch3LL merged 3 commits intoMar 2, 2021
Merged
Conversation
ghost
requested a review
from dwoz
October 16, 2020 22:52
garethgreenaway
changed the title
Akm0d
previously approved these changes
Oct 16, 2020
…numbers. This change duplicates the handling of pillar values when the pillar key points at a dictionary.
garethgreenaway
force-pushed
the
58714_query_integer_key_in_pillar
branch
from
January 5, 2021 02:00
2cca939 to
9e5608b
Compare
twangboy
approved these changes
Mar 1, 2021
Ch3LL
approved these changes
Mar 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixing an issue preventing running
pillar.getagainst pillar values with integers as pillar keys. Adding tests.What issues does this PR fix or reference?
Fixes: #58714
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.