Loader Contexts - #58853
Merged
Merged
Conversation
dwoz
force-pushed
the
loader_fixes
branch
11 times, most recently
from
November 1, 2020 21:45
ef25e7b to
91493e6
Compare
s0undt3ch
suggested changes
Nov 2, 2020
s0undt3ch
left a comment
s0undt3ch
left a comment
Contributor
There was a problem hiding this comment.
The new requirement should be added to requirements/static/pkg since it will become a hard dependency, in fact, it should actually be added to requirements/base.txt since its a hard dependency and applies to all platforms.
3 tasks
dwoz
force-pushed
the
loader_fixes
branch
2 times, most recently
from
November 2, 2020 23:25
dbef631 to
5715dde
Compare
s0undt3ch
reviewed
Nov 3, 2020
s0undt3ch
left a comment
s0undt3ch
left a comment
Contributor
There was a problem hiding this comment.
There are still a lot of print debug statements, but you should know that already.
Left some questions.
dwoz
force-pushed
the
loader_fixes
branch
5 times, most recently
from
November 5, 2020 23:08
76e3a76 to
ee93d39
Compare
s0undt3ch
previously approved these changes
Nov 8, 2020
garethgreenaway
previously approved these changes
Dec 3, 2020
s0undt3ch
approved these changes
Dec 5, 2020
garethgreenaway
approved these changes
Dec 5, 2020
This was referenced Jul 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds loader contexts so that multiple loaders can't stomp on each other.
What issues does this PR fix or reference?
Prior to these changes salt's 'magic attributes' (
__utils__,__salt__,__opts__, ect..). Would be added as global attributes to a s loaded module's namespace. This had the un-intended side effect of allowing a method call from one loader to change something in another loader. This can be particularly problematic for__context__and__opts__. This can also cause problems for loaders added with unique configs.There is also an addition of a new
pack_selfattribute to Salt'sLazyLoaderclass. This allows the loader to expose itself as a magic dunder without creating circular references on in the loader's pack dictionary. Those circular references are the cause of some memory leaks. Thepack_selfargument should be used to avoid memory leaks.Previous Behavior
Due to the global nature of Salt's dunder methods, calls from one loader could interfere with other loaders.
New Behavior
Loaders use contextvars to provide a context that is specific the the loader that loads the function being called.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.