Port pkgrepo and pkg support for Photon OS #58856

oeuftete · 2020-11-01T17:15:27Z

What does this PR do?

Ports @lomeroe's #51912 and #52550, which added pkg and pkgrepo support, respectively, for VMWare's Photon OS.

Merge requirements satisfied?

Docs
- needs reference somewhere along with annotation of the added version
Changelog - https://docs.saltstack.com/en/master/topics/development/changelog.html
Tests written/updated

Other todos

grain to match is VMware Photon OS for 3.0 at least
need to handle/disable hold/unhold
? maybe pull in add PhotonOS 3.0 #58918 locally to help testing

Commits signed with GPG?

No

salt/modules/rpm_lowpkg.py

whytewolf · 2020-12-15T21:24:45Z

Just my own two cents about this PR, Since proton, isn't its own os_family but is a Redhat variant. the os_family should be mapped to RedHat. This will make a lot of these changes have less bite as well as making the tests easier as not as many changes are needed.

oeuftete · 2020-12-15T21:36:22Z

salt/modules/rpm_lowpkg.py

Not directly related to this PR, but found this to be incorrect along the way.

oeuftete · 2020-12-15T21:42:55Z

Just my own two cents about this PR, Since proton, isn't its own os_family but is a Redhat variant. the os_family should be mapped to RedHat. This will make a lot of these changes have less bite as well as making the tests easier as not as many changes are needed.

Thanks @whytewolf, I think this is the right approach. I've made the fixes.

lomeroe · 2020-12-22T01:27:17Z

The changelog definitely needs to mention that photon will now have an os_family of "RedHat". Anyone like me using "VMware Photon OS" or "VMware Photon" in a default "grains.filter_by" statement will start getting unexpected results with that portion of the update.

s0undt3ch · 2020-12-22T10:06:14Z

The changelog definitely needs to mention that photon will now have an os_family of "RedHat". Anyone like me using "VMware Photon OS" or "VMware Photon" in a default "grains.filter_by" statement will start getting unexpected results with that portion of the update

Actually, besides mentioning this on the changelog, it's worthy of a release notes entry.

https://github.com/saltstack/salt/blob/master/doc/topics/releases/3003.rst

oeuftete · 2020-12-22T16:47:26Z

The changelog definitely needs to mention that photon will now have an os_family of "RedHat". Anyone like me using "VMware Photon OS" or "VMware Photon" in a default "grains.filter_by" statement will start getting unexpected results with that portion of the update.

@lomeroe @s0undt3ch Good feedback, thanks. I've added additional docs in 09b500a8a9.

Ch3LL · 2021-02-04T12:01:04Z

Looks like there is a merge conflict here @oeuftete

oeuftete · 2021-02-04T13:44:32Z

Looks like there is a merge conflict here @oeuftete

Thanks for the reminder @Ch3LL. Hopefully this rebase is the last one. :)

Edit 1: after all that, I think I just rebased from an old local branch... aargh
Edit 2: rebased again from what was the previous current branch (36aefcf)

…ation of dnf)

The value is "VMware Photon" only on Photon OS 1.0, where there is no python3 package available, so I think it's fair to ignore that.

sagetherage added master-port Aluminium Release Post Mg and Pre Si labels Nov 10, 2020

sagetherage added this to the Aluminium milestone Nov 10, 2020

oeuftete mentioned this pull request Nov 22, 2020

Fix failing tests on Photon OS #58991

Merged

3 tasks

oeuftete force-pushed the photonos-ports branch 3 times, most recently from 0820bbc to 14c0ade Compare November 23, 2020 02:15

oeuftete marked this pull request as ready for review November 23, 2020 02:16

oeuftete requested a review from a team as a code owner November 23, 2020 02:16

oeuftete requested review from s0undt3ch and removed request for a team November 23, 2020 02:16

oeuftete force-pushed the photonos-ports branch from 14c0ade to 14b9eaa Compare November 23, 2020 02:41

dwoz previously approved these changes Nov 24, 2020

View reviewed changes

s0undt3ch suggested changes Nov 24, 2020

View reviewed changes

salt/modules/rpm_lowpkg.py Outdated Show resolved Hide resolved

salt/modules/rpm_lowpkg.py Outdated Show resolved Hide resolved

oeuftete dismissed dwoz’s stale review via f3a7f75 November 24, 2020 20:36

oeuftete force-pushed the photonos-ports branch from f3a7f75 to a4b637a Compare November 24, 2020 20:53

oeuftete requested a review from s0undt3ch November 24, 2020 20:54

s0undt3ch previously approved these changes Nov 24, 2020

View reviewed changes

oeuftete requested a review from dwoz November 24, 2020 21:01

oeuftete dismissed s0undt3ch’s stale review via d4b8070 December 9, 2020 14:44

oeuftete force-pushed the photonos-ports branch 2 times, most recently from d4b8070 to 384a873 Compare December 15, 2020 17:26

bryceml requested a review from s0undt3ch December 15, 2020 19:54

oeuftete commented Dec 15, 2020

View reviewed changes

salt/modules/rpm_lowpkg.py Outdated

Copy link

Contributor Author

oeuftete Dec 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not directly related to this PR, but found this to be incorrect along the way.

oeuftete force-pushed the photonos-ports branch from 3430f15 to e2d90ed Compare December 15, 2020 21:41

oeuftete force-pushed the photonos-ports branch from e2d90ed to def6a1d Compare December 15, 2020 21:50

s0undt3ch previously approved these changes Dec 22, 2020

View reviewed changes

oeuftete dismissed s0undt3ch’s stale review via 8549c3f December 22, 2020 16:46

oeuftete force-pushed the photonos-ports branch from def6a1d to 8549c3f Compare December 22, 2020 16:46

oeuftete force-pushed the photonos-ports branch from 8549c3f to 09b500a Compare December 22, 2020 16:48

s0undt3ch previously approved these changes Jan 4, 2021

View reviewed changes

oeuftete dismissed s0undt3ch’s stale review via 36aefcf January 27, 2021 20:58

oeuftete force-pushed the photonos-ports branch from 09b500a to 36aefcf Compare January 27, 2021 20:58

oeuftete force-pushed the photonos-ports branch from 36aefcf to 29845cc Compare February 4, 2021 13:43

lomeroe and others added 4 commits February 4, 2021 09:48

Add VMware Photon support to pkgrepo state

bf5ee42

Let yumpkg work on VMWare's Photon OS, which uses tdnf (a C implement…

306f2b6

…ation of dnf)

Use "VMware Photon OS" instead of "VMware Photon"

b07082d

The value is "VMware Photon" only on Photon OS 1.0, where there is no python3 package available, so I think it's fair to ignore that.

Disable hold-related pkg commands for Photon OS

160f901

oeuftete force-pushed the photonos-ports branch from 29845cc to 7758627 Compare February 4, 2021 13:54

Ken Crowell added 3 commits February 4, 2021 10:27

Add support for Photon pkg integration tests

cce1f2b

Make PhotonOS part of the RedHat os_family

b4a1e33

Add notes about grains.filter_by for PhotonOS change

40c1e23

oeuftete force-pushed the photonos-ports branch from 7758627 to 40c1e23 Compare February 4, 2021 14:29

Ch3LL approved these changes Feb 4, 2021

View reviewed changes

Ch3LL requested a review from s0undt3ch February 4, 2021 17:16

s0undt3ch approved these changes Feb 4, 2021

View reviewed changes

Ch3LL merged commit 8a017c3 into saltstack:master Feb 4, 2021

oeuftete deleted the photonos-ports branch February 5, 2021 01:07

oeuftete mentioned this pull request Mar 4, 2021

[BUG] Photon3 uses TDNF package manager and pkg.install not working #59696

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Port pkgrepo and pkg support for Photon OS #58856

Port pkgrepo and pkg support for Photon OS #58856

Uh oh!

oeuftete commented Nov 1, 2020 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

whytewolf commented Dec 15, 2020

Uh oh!

oeuftete Dec 15, 2020

Uh oh!

oeuftete commented Dec 15, 2020

Uh oh!

lomeroe commented Dec 22, 2020 •

edited

Loading

Uh oh!

s0undt3ch commented Dec 22, 2020

Uh oh!

oeuftete commented Dec 22, 2020 •

edited

Loading

Uh oh!

Ch3LL commented Feb 4, 2021

Uh oh!

oeuftete commented Feb 4, 2021 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Port pkgrepo and pkg support for Photon OS #58856

Port pkgrepo and pkg support for Photon OS #58856

Uh oh!

Conversation

oeuftete commented Nov 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Merge requirements satisfied?

Other todos

Commits signed with GPG?

Uh oh!

Uh oh!

Uh oh!

whytewolf commented Dec 15, 2020

Uh oh!

oeuftete Dec 15, 2020

Choose a reason for hiding this comment

Uh oh!

oeuftete commented Dec 15, 2020

Uh oh!

lomeroe commented Dec 22, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

s0undt3ch commented Dec 22, 2020

Uh oh!

oeuftete commented Dec 22, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Ch3LL commented Feb 4, 2021

Uh oh!

oeuftete commented Feb 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

oeuftete commented Nov 1, 2020 •

edited

Loading

lomeroe commented Dec 22, 2020 •

edited

Loading

oeuftete commented Dec 22, 2020 •

edited

Loading

oeuftete commented Feb 4, 2021 •

edited

Loading