Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virt console #58859

Merged
merged 5 commits into from Dec 4, 2020
Merged

Virt console #58859

merged 5 commits into from Dec 4, 2020

Conversation

cbosdo
Copy link
Contributor

@cbosdo cbosdo commented Nov 2, 2020

What does this PR do?

Adds support for consoles and serials in the virt.running, virt.defined states and virt.init() and virt.update() execution modules. Even if some console or serial configurations may not be supported yet, this change keeps the door opened for such improvements.

This PR is an follow up of PR #56430 and supersedes it.

What issues does this PR fix or reference?

Fixes: #58844

Merge requirements satisfied?

Commits signed with GPG?

Yes

@cbosdo cbosdo requested a review from a team as a code owner November 2, 2020 13:15
@cbosdo cbosdo requested review from twangboy and removed request for a team November 2, 2020 13:15
@cbosdo cbosdo force-pushed the virt-console branch 2 times, most recently from 6132a2c to fd1fab8 Compare November 2, 2020 15:40
@cbosdo
Copy link
Contributor Author

cbosdo commented Nov 30, 2020

Rebased on master after other virt PR merges. Ready for review again

@cbosdo
Copy link
Contributor Author

cbosdo commented Nov 30, 2020

@Akm0d would you have some time to look at the PR? Way shorter than the last ones 😉

@cbosdo
Copy link
Contributor Author

cbosdo commented Dec 2, 2020

re-run pr-centos7-py3-pycryptodome-pytest

@cbosdo
Copy link
Contributor Author

cbosdo commented Dec 2, 2020

re-run pr-freebsd122-py3-pytest

@cbosdo
Copy link
Contributor Author

cbosdo commented Dec 3, 2020

@dwoz @sagetherage this PR is ready for merge too, likely to conflict with #58591

@sagetherage sagetherage added the Aluminium Release Post Mg and Pre Si label Dec 3, 2020
@dwoz dwoz merged commit 6cb22d6 into saltstack:master Dec 4, 2020
@cbosdo cbosdo deleted the virt-console branch December 4, 2020 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Aluminium Release Post Mg and Pre Si
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better serials and consoles support in the virt module
5 participants