Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add PhotonOS 3.0 #58918

Closed
wants to merge 529 commits into from
Closed

add PhotonOS 3.0 #58918

wants to merge 529 commits into from

Conversation

bryceml
Copy link
Contributor

@bryceml bryceml commented Nov 11, 2020

What does this PR do?

Adds PhotonOS 3.0 to the test suite

Note that libsodium and libgit2-devel are missing as they aren't in the photon os repos.

@bryceml bryceml requested a review from a team as a code owner November 11, 2020 00:11
@bryceml bryceml requested review from cmcmarrow and removed request for a team November 11, 2020 00:11
@bryceml bryceml added the Aluminium Release Post Mg and Pre Si label Nov 11, 2020
@bryceml bryceml added this to the Aluminium milestone Nov 11, 2020
@bryceml bryceml force-pushed the photon branch 2 times, most recently from f988a66 to a1f0536 Compare November 11, 2020 03:28
@garethgreenaway
Copy link
Contributor

#58991 should address the failing tests on Photon OS.

@bryceml
Copy link
Contributor Author

bryceml commented Mar 4, 2021

re-run full pr-photon3-py3-pytest

MKLeb and others added 25 commits January 21, 2022 10:15
Update the welcome and conclusion pages of the macOS installer
Bring some of the information in the welcome to the conclusion page
Add clarification about the salt-config cli utility
Add docs to the installation page for macOS for the installer
Add docs to the installation page for macOS for the salt-config tool
We're seeing costly grains being rendered twice due to the sentry log
handler, which unconditionally renders grains for its own use. We're not
using Sentry with salt, so it seems quite wasteful.
Reinforce sentry log handler not wasting time reloading grains/execution
modules with unit tests.
* add consul states and acl function present/absent

* add consul to states doc index

* refact/fix consul states

* fix doc, fix states

* fix name parameter for acl_changes

* fixing pylint errors

* small changes after review by @rallytime

* fix header count

* Update consul.py

* fix acl_exists description, fix when both id and name are missing

* Adding some tests for consul module and consul state module.  Some additional fixes in the consul module.

* Fixing tests.

* Fixing failing tests on Windows.

* Adding changelog.

* Adding some tests for consul module and consul state module.  Some additional fixes in the consul module.

* moving tests to pytest.

* manual black changes.

* One more manual black change.

* fixing formatting.  Adding versionadded for state module.

Co-authored-by: Rémi Jouannet <remi.jouannet@outscale.com>
Co-authored-by: Mike Place <mp@saltstack.com>
Co-authored-by: Daniel Wozniak <dwozniak@saltstack.com>
Co-authored-by: Wayne Werner <wwerner@vmware.com>
…guration as this is option is no longer used in code.
* fixes saltstack#56144 to enable hotadd profile support

* updates for black

* complying with new tests that were recently added

* Add suppor for cpuHotRemoveEnabled, nestedHVEnabled, vPMCEnabled

* Update docs for cpuHotRemoveEnabled, nestedHVEnabled, vPMCEnabled

* Add checks for platform and primary_ip and print errors if they are missing when proxy_return is set

* Add changelog

* Add changelog

* Roll back commit and properly add files

* Revert "Roll back commit and properly add files"

This reverts commit 59fd715.

* Revert "Add changelog"

This reverts commit 036fc35.

* Revert "Add checks for platform and primary_ip and print errors if they are missing when proxy_return is set"

This reverts commit 090aa3a.

Co-authored-by: nicholasmhughes <nicholasmhughes@gmail.com>
Co-authored-by: Dmitry Kuzmenko <dmitry.kuzmenko@dsr-corporation.com>
Co-authored-by: Daniel Wozniak <dwozniak@saltstack.com>
Co-authored-by: Sage the Rage <36676171+sagetherage@users.noreply.github.com>
@github-actions
Copy link

Hi! I'm your friendly PR bot!

You might be wondering what I'm doing commenting here on your PR.

Yes, as a matter of fact, I am...

I'm just here to help us improve the documentation. I can't respond to
questions or anything, but what I can do, I do well!

Okay... so what do you do?

I detect modules that are missing docstrings or "CLI Example" on existing docstrings!
When I was created we had a lot of these. The documentation for these
modules need some love and attention to make Salt better for our users.

So what does that have to do with my PR?

I noticed that in this PR there are some files changed that have some of these
issues. So I'm leaving this comment to let you know your options.

Okay, what are they?

Well, my favorite, is that since you were making changes here I'm hoping that
you would be the most familiar with this module and be able to add some other
examples or fix any of the reported issues.

If I can, then what?

Well, you can either add them to this PR or add them to another PR. Either way is fine!

Well... what if I can't, or don't want to?

That's also fine! We appreciate all contributions to the Salt Project. If you
can't add those other examples, either because you're too busy, or unfamiliar,
or you just aren't interested, we still appreciate the contributions that
you've made already.

Whatever approach you decide to take, just drop a comment here letting us know!

Detected Issues (click me)
Check Known Missing Docstrings...........................................Failed
- hook id: invoke
- duration: 2.85s
- exit code: 1

The function 'create' on 'salt/modules/boto_elb.py' does not have a 'CLI Example:' in it's docstring
The function 'delete' on 'salt/modules/boto_elb.py' does not have a 'CLI Example:' in it's docstring
The function 'set_attributes' on 'salt/modules/boto_elb.py' does not have a 'CLI Example:' in it's docstring
The function 'set_health_check' on 'salt/modules/boto_elb.py' does not have a 'CLI Example:' in it's docstring
The function 'fqdns' on 'salt/modules/network.py' does not have a 'CLI Example:' in it's docstring
The function 'avail_locations' on 'salt/cloud/clouds/hetzner.py' does not have a docstring
The function 'avail_images' on 'salt/cloud/clouds/hetzner.py' does not have a docstring
The function 'avail_sizes' on 'salt/cloud/clouds/hetzner.py' does not have a docstring
The function 'list_ssh_keys' on 'salt/cloud/clouds/hetzner.py' does not have a docstring
The function 'list_nodes_full' on 'salt/cloud/clouds/hetzner.py' does not have a docstring
The function 'list_nodes' on 'salt/cloud/clouds/hetzner.py' does not have a docstring
The function 'show_instance' on 'salt/cloud/clouds/hetzner.py' does not have a docstring
The function 'nesthash' on 'salt/modules/virt.py' does not have a 'CLI Example:' in it's docstring
The function 'init' on 'salt/modules/virt.py' does not have a 'CLI Example:' in it's docstring
The function 'node_devices' on 'salt/modules/virt.py' does not have a 'CLI Example:' in it's docstring
The function 'network_update' on 'salt/modules/virt.py' does not have a 'CLI Example:' in it's docstring
The function 'pool_update' on 'salt/modules/virt.py' does not have a 'CLI Example:' in it's docstring
The function 'virtualenv_ver' on 'salt/modules/virtualenv_mod.py' does not have a 'CLI Example:' in it's docstring
The function 'to_salt_event' on 'salt/beacons/watchdog.py' does not have a docstring
The function 'close' on 'salt/beacons/watchdog.py' does not have a docstring
The function 'setup_handlers' on 'salt/log/handlers/logstash_mod.py' does not have a docstring
The function 'zone_compare' on 'salt/modules/win_timezone.py' does not have a 'CLI Example:' in it's docstring
The function 'setup_handlers' on 'salt/log/handlers/log4mongo_mod.py' does not have a docstring
The function 'setup' on 'salt/log/handlers/fluent_mod.py' does not have a docstring
The function 'get_global_sender' on 'salt/log/handlers/fluent_mod.py' does not have a docstring
The function 'setup_handlers' on 'salt/log/handlers/fluent_mod.py' does not have a docstring
The function 'expand_repo_def' on 'salt/modules/aptpkg.py' does not have a 'CLI Example:' in it's docstring
The function 'init_kwargs' on 'salt/cache/localfs.py' does not have a docstring
The function 'get_storage_id' on 'salt/cache/localfs.py' does not have a docstring
The function 'get_package_info' on 'salt/modules/win_pkg.py' does not have a 'CLI Example:' in it's docstring
The function 'ping_all_connected_minions' on 'salt/utils/master.py' does not have a docstring
The function 'get_master_key' on 'salt/utils/master.py' does not have a docstring
The function 'validate' on 'salt/beacons/salt_monitor.py' does not have a docstring
The function 'beacon' on 'salt/beacons/salt_monitor.py' does not have a docstring
The function 'help' on 'salt/modules/ansiblegate.py' was previously known to not have a CLI Example, which is no longer the case. Please remove it from 'MISSING_EXAMPLES'. in 'tasks/docstrings.py'
The function 'list_' on 'salt/modules/ansiblegate.py' was previously known to not have a CLI Example, which is no longer the case. Please remove it from 'MISSING_EXAMPLES'. in 'tasks/docstrings.py'
The function 'verify_logs_filter' on 'salt/utils/verify.py' does not have a docstring
The function 'exist' on 'salt/modules/chroot.py' was previously known to not have a CLI Example, which is no longer the case. Please remove it from 'MISSING_EXAMPLES'. in 'tasks/docstrings.py'
The function 'close' on 'salt/beacons/inotify.py' does not have a docstring
The function 'init_kwargs' on 'salt/cache/redis_cache.py' does not have a docstring
The function 'zap' on 'salt/modules/ceph.py' does not have a 'CLI Example:' in it's docstring
The function 'recv' on 'salt/modules/cp.py' was previously known to not have a CLI Example, which is no longer the case. Please remove it from 'MISSING_EXAMPLES'. in 'tasks/docstrings.py'
The function 'recv_chunked' on 'salt/modules/cp.py' was previously known to not have a CLI Example, which is no longer the case. Please remove it from 'MISSING_EXAMPLES'. in 'tasks/docstrings.py'
The function 'envs' on 'salt/modules/cp.py' was previously known to not have a CLI Example, which is no longer the case. Please remove it from 'MISSING_EXAMPLES'. in 'tasks/docstrings.py'
The function 'debug' on 'salt/modules/logmod.py' does not have a 'CLI Example:' in it's docstring
The function 'info' on 'salt/modules/logmod.py' does not have a 'CLI Example:' in it's docstring
The function 'warning' on 'salt/modules/logmod.py' does not have a 'CLI Example:' in it's docstring
The function 'error' on 'salt/modules/logmod.py' does not have a 'CLI Example:' in it's docstring
The function 'critical' on 'salt/modules/logmod.py' does not have a 'CLI Example:' in it's docstring
The function 'exception' on 'salt/modules/logmod.py' does not have a 'CLI Example:' in it's docstring
The function 'get_pauses' on 'salt/modules/state.py' does not have a 'CLI Example:' in it's docstring
The function 'apply_' on 'salt/modules/state.py' does not have a 'CLI Example:' in it's docstring
The function 'test' on 'salt/modules/state.py' does not have a 'CLI Example:' in it's docstring
The function 'systemd_notify_call' on 'salt/utils/process.py' does not have a docstring
The function 'default_signals' on 'salt/utils/process.py' does not have a docstring
The function 'post_master_init' on 'salt/metaproxy/proxy.py' was previously known to not have a docstring, which is no longer the case. Please remove it from 'MISSING_DOCSTRINGS' .in 'tasks/docstrings.py'
The function 'target' on 'salt/metaproxy/proxy.py' was previously known to not have a docstring, which is no longer the case. Please remove it from 'MISSING_DOCSTRINGS' .in 'tasks/docstrings.py'
The function 'handle_payload' on 'salt/metaproxy/proxy.py' was previously known to not have a docstring, which is no longer the case. Please remove it from 'MISSING_DOCSTRINGS' .in 'tasks/docstrings.py'
The function 'target_load' on 'salt/metaproxy/proxy.py' was previously known to not have a docstring, which is no longer the case. Please remove it from 'MISSING_DOCSTRINGS' .in 'tasks/docstrings.py'
Found 10 warnings
Found 49 errors


Thanks again!

@garethgreenaway
Copy link
Contributor

This one is super old and outdated, closing it out in favor of #61500

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-failing-test merge-conflict PR has a merge conflict Phosphorus v3005.0 Release code name and version Test-Failure Fix the CI failure ⛈
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet