New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add PhotonOS 3.0 #58918
add PhotonOS 3.0 #58918
Conversation
f988a66
to
a1f0536
Compare
#58991 should address the failing tests on Photon OS. |
0b8fb0f
to
276f717
Compare
re-run full pr-photon3-py3-pytest |
Update the welcome and conclusion pages of the macOS installer Bring some of the information in the welcome to the conclusion page Add clarification about the salt-config cli utility Add docs to the installation page for macOS for the installer Add docs to the installation page for macOS for the salt-config tool
We're seeing costly grains being rendered twice due to the sentry log handler, which unconditionally renders grains for its own use. We're not using Sentry with salt, so it seems quite wasteful.
Reinforce sentry log handler not wasting time reloading grains/execution modules with unit tests.
…directory contents
* add consul states and acl function present/absent * add consul to states doc index * refact/fix consul states * fix doc, fix states * fix name parameter for acl_changes * fixing pylint errors * small changes after review by @rallytime * fix header count * Update consul.py * fix acl_exists description, fix when both id and name are missing * Adding some tests for consul module and consul state module. Some additional fixes in the consul module. * Fixing tests. * Fixing failing tests on Windows. * Adding changelog. * Adding some tests for consul module and consul state module. Some additional fixes in the consul module. * moving tests to pytest. * manual black changes. * One more manual black change. * fixing formatting. Adding versionadded for state module. Co-authored-by: Rémi Jouannet <remi.jouannet@outscale.com> Co-authored-by: Mike Place <mp@saltstack.com> Co-authored-by: Daniel Wozniak <dwozniak@saltstack.com> Co-authored-by: Wayne Werner <wwerner@vmware.com>
…guration as this is option is no longer used in code.
* fixes saltstack#56144 to enable hotadd profile support * updates for black * complying with new tests that were recently added * Add suppor for cpuHotRemoveEnabled, nestedHVEnabled, vPMCEnabled * Update docs for cpuHotRemoveEnabled, nestedHVEnabled, vPMCEnabled * Add checks for platform and primary_ip and print errors if they are missing when proxy_return is set * Add changelog * Add changelog * Roll back commit and properly add files * Revert "Roll back commit and properly add files" This reverts commit 59fd715. * Revert "Add changelog" This reverts commit 036fc35. * Revert "Add checks for platform and primary_ip and print errors if they are missing when proxy_return is set" This reverts commit 090aa3a. Co-authored-by: nicholasmhughes <nicholasmhughes@gmail.com> Co-authored-by: Dmitry Kuzmenko <dmitry.kuzmenko@dsr-corporation.com> Co-authored-by: Daniel Wozniak <dwozniak@saltstack.com> Co-authored-by: Sage the Rage <36676171+sagetherage@users.noreply.github.com>
Hi! I'm your friendly PR bot!You might be wondering what I'm doing commenting here on your PR. Yes, as a matter of fact, I am... I'm just here to help us improve the documentation. I can't respond to Okay... so what do you do? I detect modules that are missing docstrings or "CLI Example" on existing docstrings! So what does that have to do with my PR? I noticed that in this PR there are some files changed that have some of these Okay, what are they? Well, my favorite, is that since you were making changes here I'm hoping that If I can, then what? Well, you can either add them to this PR or add them to another PR. Either way is fine! Well... what if I can't, or don't want to? That's also fine! We appreciate all contributions to the Salt Project. If you Whatever approach you decide to take, just drop a comment here letting us know! Detected Issues (click me)Check Known Missing Docstrings...........................................Failed - hook id: invoke - duration: 2.85s - exit code: 1 Thanks again! |
This one is super old and outdated, closing it out in favor of #61500 |
What does this PR do?
Adds PhotonOS 3.0 to the test suite
Note that
libsodium
andlibgit2-devel
are missing as they aren't in the photon os repos.