Restconf proxy#58965
Conversation
|
Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar. |
waynew
left a comment
There was a problem hiding this comment.
Thanks for the PR! Just a few things that I noticed while reviewing for test clinic
Co-authored-by: Wayne Werner <waynejwerner@gmail.com>
Co-authored-by: Wayne Werner <waynejwerner@gmail.com>
… restconf-proxy
|
@waynew bad uri: unreachable host: The states code has logic written around the status code response. |
Co-authored-by: Pedro Algarvio <pedro@algarvio.me>
Co-authored-by: Pedro Algarvio <pedro@algarvio.me>
Co-authored-by: Pedro Algarvio <pedro@algarvio.me>
Co-authored-by: Pedro Algarvio <pedro@algarvio.me>
|
re-run centos-7 |
|
re-run centos |
|
re-run amazon-2 |
|
re-run amazon-2 |
|
@dmurphy18 do you think this will get merged in v3005? its finally passing all tests but i see its awaiting re-review still |
|
@ITJamie Yes, we had discussion in the team and have decided to include this PR in the Phosphorous Release (3005). The Team is a little busy at the moment but it is currently scheduled to be included. |
|
Congratulations on your first PR being merged! 🎉 |
What does this PR do?
New Behavior
Adding a RestConf proxy module for working with network devices like cisco,juniper etc
Issue: #59006
Merge requirements satisfied?
Commits signed with GPG?
No