Replace some jenkins jobs with a GH Actions#58983
Merged
dwoz merged 6 commits intosaltstack:masterfrom Nov 30, 2020
Merged
Conversation
s0undt3ch
force-pushed
the
hotfix/github-actions
branch
17 times, most recently
from
7dbb948 to
758ab1e
Compare
s0undt3ch
changed the title
krionbsd
previously approved these changes
Nov 19, 2020
s0undt3ch
force-pushed
the
hotfix/github-actions
branch
2 times, most recently
from
8cfa4b8 to
91b6476
Compare
Contributor
Author
|
GH Actions switched to docker containers |
bryceml
previously approved these changes
Nov 19, 2020
s0undt3ch
force-pushed
the
hotfix/github-actions
branch
from
91b6476 to
9482420
Compare
s0undt3ch
force-pushed
the
hotfix/github-actions
branch
2 times, most recently
from
8d0b9a7 to
50f1d09
Compare
bryceml
previously approved these changes
Nov 19, 2020
s0undt3ch
force-pushed
the
hotfix/github-actions
branch
from
50f1d09 to
f792fad
Compare
krionbsd
previously approved these changes
Nov 20, 2020
s0undt3ch
force-pushed
the
hotfix/github-actions
branch
2 times, most recently
from
48be061 to
0f19d74
Compare
krionbsd
previously approved these changes
Nov 25, 2020
Contributor
ScriptAutomate
left a comment
ScriptAutomate
left a comment
There was a problem hiding this comment.
This is so awesome that we are migrating stuff to GitHub Actions! It's great that I can see what these actions are doing via the Check tab of the PR:
The only confirmation I'd like make is about this section where a Good, Bad, Good example set exists, though I think it is intended to have only one Good and one Bad? Just want to confirm whether it is intentional:
Contributor
Author
|
I can make it just one Good and one Bad, two good and one Bad was intentional since they refer to different things. |
s0undt3ch
force-pushed
the
hotfix/github-actions
branch
from
0f19d74 to
ba5d65c
Compare
ScriptAutomate
previously approved these changes
Nov 26, 2020
s0undt3ch
force-pushed
the
hotfix/github-actions
branch
from
ba5d65c to
cb1a6e8
Compare
dwoz
approved these changes
Nov 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
See title