New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SCRAM-SHA-256 support to postgres states #59034
Conversation
I did a manual integration test. If it's possible for someone to add something with some postgres Docker images that would be awesome. |
8e28b03
to
24c802a
Compare
Since this is a new feature and is pretty cool, can we get it added to |
(How) do I do that? |
@OrangeDog You'll want to add some information to the release notes for 3003, which can be found here: |
@OrangeDog Apologies for the delay in getting to this. Since we missed the 3003 release, would you be able to update the PR to have the note in release notes for the Aluminum release? Thanks! |
But Aluminium is 3003... |
I think Gareth might be confused in that comment. @OrangeDog there was a test that cancelled out, but I have updated this PR with the
|
@Ch3LL this is looking close |
Looks good. @Ch3LL when you get a chance this one is ready to go. |
import salt.states.postgres_group as postgres_group | ||
from tests.support.mock import create_autospec, patch | ||
|
||
DB_ARGS = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as here
Co-authored-by: Pedro Algarvio <pedro@algarvio.me>
Co-authored-by: Pedro Algarvio <pedro@algarvio.me>
It looks like adding the lines back to |
That is correct and a limitation on Windows which should be addressed. Right now, I've triggered the full test suite run for both Windows which bypasses this problem |
I'm going to merge this for Aluminum, @OrangeDog Please create a ticket for the issue which needs to be addressed on windows. |
What does this PR do?
Adds SCRAM-SHA-256 support to postgres states.
What issues does this PR fix or reference?
Fixes: #51217
Previous Behavior
See referenced issue. Only plaintext and MD5 passwords supported.
New Behavior
If
encrypted=scram-sha-256
is passed to thepostgres_user.present
orpostgres_group.present
states then the SCRAM-SHA-256 algorithm is used.Other minor issues fixed:
postgres_group.absent
postgres_group.present
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.