Always store git sha in _version.py during installation - #59137
Merged
Conversation
bryceml
force-pushed
the
always_store_git_sha
branch
from
December 14, 2020 19:53
f8b39ba to
4b1ba6e
Compare
bryceml
force-pushed
the
always_store_git_sha
branch
from
December 14, 2020 19:58
4b1ba6e to
6beea2b
Compare
bryceml
marked this pull request as ready for review
December 14, 2020 21:26
Ch3LL
suggested changes
Dec 16, 2020
Ch3LL
left a comment
Ch3LL
left a comment
Contributor
There was a problem hiding this comment.
What's the use case where you would need the sha? I would assume when you tag a version you only want the tag version not the sha included
Contributor
Author
|
It doesn't show up graphically anywhere, or in any output. It's mainly so when we do the nightly builds, you can track down the exact sha it came from. For the non-tiamat packages, you can't have a |
Ch3LL
approved these changes
Dec 16, 2020
s0undt3ch
approved these changes
Jan 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It always puts the git sha in salt/_version.py when it's generating it's version automatically.
The main difference that tagged versions will include the git sha in that file so it can be figured out later what exact sha is being run, I don't think there should be any other changes anywhere.
What issues does this PR fix or reference?
Previous Behavior
tagged versions did not store the git sha
New Behavior
tagged versions also store the git sha
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.