New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement TCP transport reqchannel retry logic #59163
Conversation
FYI @waynew. Thanks |
7b8c328
to
0a3e1dc
Compare
re-run pr-ubuntu1604-py3-pytest |
nice 👍 |
Should probably be merged after #59172 , so there is no conflict with tests |
Also, fyi, #59172 has been merged. |
re-run pr-amazon2-py3-pytest |
bump. any reason not to merge this? |
I expect due to the upcoming CVE release the merging has been postponed. Anyway, I've rebased it, so it's up-to-date with master, updated the test with larger |
re-run pr-centos7-py3-pytest |
re-run pr-freebsd122-py3-pytest |
re-run pr-centos7-py3-pytest |
What does this PR do?
Implements retry mechanism for TCP transports ReqChannel as it's currently done for ZeroMQ.
What issues does this PR fix or reference?
Fixes #59162
Previous Behavior
Once first publish fails, event is lost forever
New Behavior
Event publish is retried multiple times
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes