You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I would love to get your insight into the test implementation, the currently implemented integration test requires setting fixed return_retry_timer in default conf files in order to have it at least a bit deterministic and I haven't found an easy option how to set specific opts for single test (except creating new fixture with own minion factory).
I expect due to the upcoming CVE release the merging has been postponed.
Anyway, I've rebased it, so it's up-to-date with master, updated the test with larger return_retry_tries (as the PR for that has been merged, so it could work much better without such large sleep) and changed the slowTest decorator to pytest mark, FYI @s0undt3ch
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.