Set state_output_profile as option and update docs#59165
Merged
Ch3LL merged 7 commits intoFeb 23, 2021
Conversation
Contributor
Author
|
Of note: I also opened #59166 after noticing that we may need to extend the |
waynew
suggested changes
Jan 19, 2021
waynew
left a comment
Contributor
There was a problem hiding this comment.
Looks like in JsonNestedTestCase in the setup_loader_modules function you'll need to add "state_output_profile": True, as well
Contributor
Author
Ch3LL
approved these changes
Feb 23, 2021
twangboy
approved these changes
Feb 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
state_output_profileas an option inmasterandminionconfigsstate_output_profileas an option tosalt/config/__init__.py, validating as aboolstate_output_profileas having default value ofTrueinminionandmasterconfigssalt/output/highstate.pyto no longer hard-code default value forstate_output_profileWhat issues does this PR fix or reference?
Ongoing work related to: #58112
It looks like
state_output_profilewas meant to be an option, but was instead hard-coded intosalt/output/highstate.pywhen the value and option should have been documented for minion/master configurations.Previous Behavior
Undocumented option.
New Behavior
Documented option.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes