Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #59161 #59177

Merged
merged 4 commits into from Jan 7, 2021
Merged

Fix #59161 #59177

merged 4 commits into from Jan 7, 2021

Conversation

avkvl
Copy link

@avkvl avkvl commented Dec 19, 2020 •
edited

What does this PR do?

add "CentOS Stream" to _OS_FAMILY_MAP

What issues does this PR fix or reference?

Fixes: #59161

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

@avkvl avkvl requested a review from a team as a code owner December 19, 2020 19:43
@avkvl avkvl requested review from twangboy and removed request for a team December 19, 2020 19:43
@welcome
Copy link

welcome bot commented Dec 19, 2020

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at core@saltstack.com. We’re glad you’ve joined our community and look forward to doing awesome things with you!

@avkvl avkvl changed the title Fix 59161 Fix #59161 Dec 19, 2020
@t0fik t0fik mentioned this pull request Jan 4, 2021
Closed
@krionbsd
Copy link
Contributor

krionbsd commented Jan 7, 2021

@avkvl PR 59201 should fix this issue

@avkvl
Copy link
Author

avkvl commented Jan 7, 2021

@avkvl PR 59201 should fix this issue

Yes, PR 59201 will fix package installation, but will not set grain os_family to RedHat.

@krionbsd
Copy link
Contributor

krionbsd commented Jan 7, 2021

@avkvl PR 59201 should fix this issue

Yes, PR 59201 will fix package installation, but will not set grain os_family to RedHat.

yes, sorry I missed this part

@dwoz dwoz merged commit 9576bbe into saltstack:master Jan 7, 2021
23 checks passed
@welcome
Copy link

welcome bot commented Jan 7, 2021

Congratulations on your first PR being merged! 🎉

@avkvl avkvl deleted the fix_59161 branch January 11, 2021 07:16
@sagetherage sagetherage added the Aluminium Release Post Mg and Pre Si label Feb 18, 2021
@johnnybubonic johnnybubonic mentioned this pull request Mar 25, 2021
Closed
@Ch3LL Ch3LL mentioned this pull request Mar 31, 2021
Closed
@ScriptAutomate
Copy link
Contributor

Potentially related: #59061

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krionbsd krionbsd krionbsd approved these changes

@twangboy twangboy

Assignees
No one assigned
Labels
Aluminium Release Post Mg and Pre Si
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3002.6 regression salt minion broken in CentOS Stream
5 participants
@avkvl @krionbsd @ScriptAutomate @dwoz @sagetherage