Changed package manager detection #59201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t0fik
force-pushed
the
fix_pkgrepo_copr_in_dnf
branch
2 times, most recently
from
2e5c8c9 to
b995639
Compare
t0fik
force-pushed
the
fix_pkgrepo_copr_in_dnf
branch
from
b995639 to
5ff1f6d
Compare
t0fik
force-pushed
the
fix_pkgrepo_copr_in_dnf
branch
from
c68a7eb to
d3288f6
Compare
t0fik
force-pushed
the
fix_pkgrepo_copr_in_dnf
branch
from
5bc2f45 to
02dbe45
Compare
Contributor
|
re-run freebsd122 |
krionbsd
approved these changes
Jan 6, 2021
garethgreenaway
pushed a commit
to garethgreenaway/salt
that referenced
this pull request
Jan 14, 2021
* Changed package manager detection * Added os import inside _yum function * Added changelog * Added patching __context__ dict * Added condition for DNF installed on CentOS7 * Added _versionlock_pkg function * Changed ret variable name * Added second test install * Conditional package change check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changes detection of which package manager is used yum or dnf.
What issues does this PR fix or reference?
Fixed wrong package manager detection (YUM detected instead DNF) in Centos Stream,
issue manifests after resolving #59161
Previous Behavior
Detection was based on comparing
osgrain with fixed os name list.New Behavior
os.environ['PATH']oros.defpath, first found is set.Priority:
dnf,yum__virtual__function returnsfalseif DNF nor YUM could be found.Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
No