Repository navigation
Support powershell core - #59240
Support powershell core#59240
Conversation
s0undt3ch
left a comment
There was a problem hiding this comment.
My only real concern are f-strings but, if Debian 9 and Ubuntu 16.04 don't choke, I'm cool with it.
|
Yep. Debian 9 choked. We can't, yet, use |
|
Does it fix these issues? |
|
@max-arnold Yeah, I think so... I'll add some tests around your example |
|
@max-arnold Your first comment using With As a note, this seems to only affect older versions of powershell. I don't get the raw xml data with Powershell Core, so maybe they've addressed that issue there. |
7a263f5 to
2aa779d
Compare
a4edb3e to
342a501
Compare
d84835a to
6a5b410
Compare
8247623 to
78d03cf
Compare
f275888 to
c47c3b1
Compare
7c8ba59 to
f209edc
Compare
84ce9b4 to
823e16f
Compare
|
Not sure why Fedora 33 is failing... Everything else is passing |
This reverts commit 225328484b22dda769257c89eedb6a60129272b5.
This reverts commit 225328484b22dda769257c89eedb6a60129272b5.
This reverts commit 225328484b22dda769257c89eedb6a60129272b5.
854b212 to
28f128b
Compare
What does this PR do?
Adds support for powershell core. The binary for powershell core is
pwsh. Added tests.Fixes running encoded powershell commands. This broke in Python 3, but we didn't know it. Added tests.
Moves a couple integration tests to pytest/functional
Powershell core is added to the golden image in this PR: https://github.com/saltstack/salt-jenkins/pull/1688
When present, tests will run for pwsh binaries
What issues does this PR fix or reference?
Fixes: #58598
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.