Fixes to event function in state module #59260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… we can convert those when they show in events.
s0undt3ch
previously approved these changes
Jan 8, 2021
s0undt3ch
previously approved these changes
Jan 9, 2021
…t and decode_dict.
s0undt3ch
previously approved these changes
Jan 10, 2021
… look for specific strings in the call args, eg. the datetime and the encoded bytes string.
s0undt3ch
approved these changes
Jan 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
What does this PR do?
Make sure that the data being passed to salt.utils.json.dumps is in the right format.
Update salt.utils.data.decode to properly handle datetime objects, so we can convert those when they show in events.
What issues does this PR fix or reference?
Fixes: #59222 #56389 #57349
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes/No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.