Skip to content

Fixes to event function in state module #59260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 22, 2021

Conversation

garethgreenaway
Copy link
Contributor

@garethgreenaway garethgreenaway commented Jan 8, 2021

What does this PR do?

Make sure that the data being passed to salt.utils.json.dumps is in the right format.
Update salt.utils.data.decode to properly handle datetime objects, so we can convert those when they show in events.

What issues does this PR fix or reference?

Fixes: #59222 #56389 #57349

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes/No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@garethgreenaway garethgreenaway requested a review from a team as a code owner January 8, 2021 21:23
@garethgreenaway garethgreenaway requested review from xeacott and removed request for a team January 8, 2021 21:23
s0undt3ch
s0undt3ch previously approved these changes Jan 8, 2021
@sagetherage sagetherage added the Aluminium Release Post Mg and Pre Si label Jan 8, 2021
s0undt3ch
s0undt3ch previously approved these changes Jan 9, 2021
s0undt3ch
s0undt3ch previously approved these changes Jan 10, 2021
… look for specific strings in the call args, eg. the datetime and the encoded bytes string.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Aluminium Release Post Mg and Pre Si
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] webhook engine events work with salt event runner in 2018.3.2 and not after 2019.2.0
4 participants