Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding salt key rotation guidance and link the hardening doc to the Salt best practices doc #59271

Merged
merged 6 commits into from Feb 1, 2021
Merged

Adding salt key rotation guidance and link the hardening doc to the Salt best practices doc #59271

merged 6 commits into from Feb 1, 2021

Conversation

ScriptAutomate
Copy link
Contributor

@ScriptAutomate ScriptAutomate commented Jan 11, 2021

What does this PR do?

What issues does this PR fix or reference?

Fixes: #57725

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

  • Docs

Commits signed with GPG?

Yes

@ScriptAutomate ScriptAutomate added Documentation Relates to Salt documentation doc-rst-update .rst file edits labels Jan 11, 2021
@ScriptAutomate ScriptAutomate requested a review from a team as a code owner January 11, 2021 23:48
@ScriptAutomate ScriptAutomate requested review from s0undt3ch and removed request for a team January 11, 2021 23:48
@ScriptAutomate ScriptAutomate added the Aluminium Release Post Mg and Pre Si label Jan 12, 2021
twangboy
twangboy previously approved these changes Jan 13, 2021
@ScriptAutomate ScriptAutomate changed the title Adding salt-rekey guidance and link the hardening doc to the Salt best practices doc Adding salt key rotation guidance and link the hardening doc to the Salt best practices doc Jan 22, 2021
@ScriptAutomate
Copy link
Contributor Author

ScriptAutomate commented Jan 22, 2021

I've removed docs links to salt-rekey, due to that tool not being managed by the SaltStack org on GitHub, and for the disclaimer it is released under:

This script is provided without any fitness or warranty. It may cause minions to be disconnected from the Salt master and fail to reconnect, forcing manual intervention.

I have created the following feature request as a follow-up: #59342

Ch3LL
Ch3LL previously approved these changes Jan 29, 2021
SECURITY.md Outdated Show resolved Hide resolved
dwoz
dwoz previously approved these changes Jan 29, 2021
SECURITY.md Outdated Show resolved Hide resolved
Fix hardening blog link
@Ch3LL Ch3LL merged commit 1012903 into saltstack:master Feb 1, 2021
19 of 23 checks passed
@ScriptAutomate ScriptAutomate deleted the doc-rotate-keys branch February 2, 2021 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Aluminium Release Post Mg and Pre Si doc-rst-update .rst file edits Documentation Relates to Salt documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] New doc on rotating keys
8 participants