Repository navigation
Fix salt version PEP440 compliance - #59359
Merged
Merged
Conversation
krionbsd
previously approved these changes
Jan 26, 2021
The wheel metadata version 1.2 states that the package version MUST be PEP440 compliant. This means that instead of `3002.2-511-g033c53eccb`, the salt version string should look like `3002.2+511.g033c53eccb`, a post release of `3002.2` ahead by 511 commits with the git sha `033c53eccb`
s0undt3ch
force-pushed
the
hotfix/setup-tests
branch
from
January 26, 2021 17:33
ca34fbb to
6a975d3
Compare
bryceml
previously approved these changes
Jan 26, 2021
bryceml
left a comment
bryceml
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, I do wonder if we should remove anything from the regex that's not pep440 compliant, like nb, not sure if alpha or beta are pep440 compliant either.
s0undt3ch
force-pushed
the
hotfix/setup-tests
branch
3 times, most recently
from
January 27, 2021 08:59
8a58120 to
7ff0a23
Compare
krionbsd
self-requested a review
January 27, 2021 09:02
krionbsd
previously approved these changes
Jan 27, 2021
s0undt3ch
force-pushed
the
hotfix/setup-tests
branch
from
January 27, 2021 09:56
7ff0a23 to
d9c8214
Compare
saltstack-formulas-github
pushed a commit
to netmanagers/salt-image-builder
that referenced
this pull request
Feb 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix PEP440 compliance.
The wheel metadata version 1.2 states that the package version MUST be
PEP440 compliant.
This means that instead of
3002.2-511-g033c53eccb, the salt versionstring should look like
3002.2+511.g033c53eccb, a post release of3002.2ahead by 511 commits with the git sha033c53eccb