Salt Cloud fixes #59374
Merged
Salt Cloud fixes #59374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s0undt3ch
force-pushed
the
hotfix/cloud
branch
3 times, most recently
from
f8fca46
to
3e76290
Compare
s0undt3ch
force-pushed
the
hotfix/cloud
branch
8 times, most recently
from
d663d28
to
14bf8bb
Compare
s0undt3ch
force-pushed
the
hotfix/cloud
branch
from
14bf8bb
to
cc8f7ad
Compare
krionbsd
previously approved these changes
Feb 5, 2021
s0undt3ch
force-pushed
the
hotfix/cloud
branch
from
cc8f7ad
to
1c1e0a9
Compare
|
@s0undt3ch do we need to update libcloud then? That's going to be a bit of work, most oses provide 2.2 I think. |
|
The libcloud requirent stays at 1.5.0, however, to use GCE, 2.5.0 is required. |
s0undt3ch
force-pushed
the
hotfix/cloud
branch
from
1c1e0a9
to
7d9c90a
Compare
s0undt3ch
force-pushed
the
hotfix/cloud
branch
from
256e9fe
to
f90d419
Compare
krionbsd
previously approved these changes
Feb 9, 2021
Ch3LL
requested changes
Feb 9, 2021
|
Yes, unit tests. There is joyent unit tests currently but would be good to add one for the new change with node state (for example this method: joyent_node_state). I'm fine adding the tests in a separate PR. |
Ch3LL
previously approved these changes
Feb 9, 2021
|
FYI, no new functionality was added to joyent. It was relying on a function from libcloud which no longer makes sense, but since we don't run integration tests against joyent, I just copied that function to joyent in order not to break it, that was it. |
garethgreenaway
previously approved these changes
Feb 9, 2021
s0undt3ch
dismissed stale reviews from garethgreenaway, Ch3LL, and krionbsd
via
80bb35e
s0undt3ch
force-pushed
the
hotfix/cloud
branch
4 times, most recently
from
fd6bf50
to
550e597
Compare
s0undt3ch
force-pushed
the
hotfix/cloud
branch
from
550e597
to
1959a42
Compare
```python
Traceback (most recent call last):
File "/tmp/kitchen/testing/salt/cloud/__init__.py", line 2349, in run_parallel_map_providers_query
salt.utils.data.simple_types_filter(cloud.clouds[data["fun"]]()),
File "/tmp/kitchen/testing/salt/loader.py", line 1182, in __call__
return self.loader.run(run_func, *args, **kwargs)
File "/tmp/kitchen/testing/salt/loader.py", line 2204, in run
return self._last_context.run(self._run_as, method, *args, **kwargs)
File "/tmp/kitchen/testing/.nox/pytest-cloud-3-coverage-false/lib/python3.6/site-packages/contextvars/__init__.py", line 38, in run
return callable(*args, **kwargs)
File "/tmp/kitchen/testing/salt/loader.py", line 2219, in _run_as
return method(*args, **kwargs)
File "/tmp/kitchen/testing/salt/cloud/clouds/vultrpy.py", line 163, in list_nodes
nodes = list_nodes_full()
File "/tmp/kitchen/testing/salt/cloud/clouds/vultrpy.py", line 176, in list_nodes_full
nodes = _query("server/list")
File "/tmp/kitchen/testing/salt/cloud/clouds/vultrpy.py", line 530, in _query
opts=__opts__,
File "/tmp/kitchen/testing/salt/loader.py", line 1182, in __call__
return self.loader.run(run_func, *args, **kwargs)
TypeError: run() got multiple values for argument 'method'
```
s0undt3ch
force-pushed
the
hotfix/cloud
branch
from
1959a42
to
41a670c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
See title
salt-cloudfailing to list nodes for recent versions ofapache-libcloud#56589salt-cloudFailed to get the output of 'gce.avail_images()' #56862