Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle gracefully -f (--find-links) in "pip freeze" and report error in ... #5938

Merged
merged 2 commits into from Jul 4, 2013
Merged

handle gracefully -f (--find-links) in "pip freeze" and report error in ... #5938

merged 2 commits into from Jul 4, 2013

Conversation

jeanlucmongrain
Copy link
Contributor

...output

this bug had been introduced in 0.16

pip freeze can return more then -e and ==.

the if/elif logic caused this:

   File "/usr/lib/pymodules/python2.6/salt/modules/pip.py", line 574, in list_
     packages[name] = version
UnboundLocalError: local variable 'version' referenced before assignment

when pip freeze output isn't handled, it log it as an error. but I think this should make pip.list fail.
what is the best to do in salt modules that don't return a dict {'result': False, ...} ?

techhat added a commit that referenced this pull request Jul 4, 2013
handle gracefully -f (--find-links) in "pip freeze" and report error in ...
@techhat techhat merged commit 1567235 into saltstack:0.16 Jul 4, 2013
@jeanlucmongrain jeanlucmongrain deleted the 0.16-pip-issue branch July 4, 2013 13:42
@basepi
Copy link
Contributor

basepi commented Aug 19, 2013

In the future, please submit pull requests against develop, not 0.16 -- someone just pointed out that this fix is not in develop. Cherry-picking it across now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants