Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the ability to clear and show the pillar cache enabled when pillar_cache is True. #59411

Merged
merged 17 commits into from Feb 19, 2021

Conversation

garethgreenaway
Copy link
Contributor

@garethgreenaway garethgreenaway commented Feb 3, 2021

What does this PR do?

Adding the ability to clear and show the pillar cache enabled when pillar_cache is True.

What issues does this PR fix or reference?

Fixes: #37080

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@garethgreenaway garethgreenaway requested a review from a team as a code owner February 3, 2021 21:12
@garethgreenaway garethgreenaway requested review from twangboy and removed request for a team February 3, 2021 21:12
@garethgreenaway garethgreenaway added the Aluminium Release Post Mg and Pre Si label Feb 3, 2021
salt/runners/pillar.py Outdated Show resolved Hide resolved
salt/runners/pillar.py Outdated Show resolved Hide resolved
tests/unit/runners/test_pillar.py Outdated Show resolved Hide resolved
@Ch3LL Ch3LL requested a review from dwoz February 8, 2021 11:26
salt/runners/pillar.py Outdated Show resolved Hide resolved
@garethgreenaway garethgreenaway requested review from Ch3LL, twangboy and s0undt3ch and removed request for dwoz February 11, 2021 18:31
twangboy
twangboy previously approved these changes Feb 11, 2021
s0undt3ch
s0undt3ch previously approved these changes Feb 11, 2021
Copy link
Member

@s0undt3ch s0undt3ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a change but it's not a blocker

salt/runners/pillar.py Outdated Show resolved Hide resolved
s0undt3ch
s0undt3ch previously approved these changes Feb 12, 2021
salt/runners/pillar.py Outdated Show resolved Hide resolved
Removing hardcoded saltenv.  Setting default for saltenv to base.
s0undt3ch
s0undt3ch previously approved these changes Feb 17, 2021
salt/runners/pillar.py Show resolved Hide resolved
salt/runners/pillar.py Show resolved Hide resolved
tests/pytests/unit/runners/test_pillar.py Outdated Show resolved Hide resolved
Copy link
Member

@s0undt3ch s0undt3ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

salt/runners/pillar.py Outdated Show resolved Hide resolved
salt/runners/pillar.py Outdated Show resolved Hide resolved
@Ch3LL Ch3LL merged commit 05a9ff1 into saltstack:master Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Aluminium Release Post Mg and Pre Si
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clearing pillar cache from Master leaves stray files & does not appear to clear it
4 participants