Skip to content

Wean off IOLoop.run_sync #59459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2021
Merged

Wean off IOLoop.run_sync #59459

merged 1 commit into from
Mar 4, 2021

Conversation

dwoz
Copy link
Contributor

@dwoz dwoz commented Feb 9, 2021

What does this PR do?

Add some more changes in preparation for tornado 5.1.1

What issues does this PR fix or reference?

Fixes:

Previous Behavior

Remove this section if not relevant

New Behavior

Remove this section if not relevant

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes/No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@dwoz dwoz requested a review from a team as a code owner February 9, 2021 03:53
@dwoz dwoz requested review from garethgreenaway and removed request for a team February 9, 2021 03:53
@dwoz dwoz marked this pull request as draft February 9, 2021 03:53
@dwoz dwoz added the Aluminium Release Post Mg and Pre Si label Feb 9, 2021
@dwoz dwoz force-pushed the less_run_sync branch 3 times, most recently from 2105e11 to 23bd166 Compare February 9, 2021 19:45
@dwoz
Copy link
Contributor Author

dwoz commented Feb 10, 2021

re-run full all

@dwoz dwoz changed the title [WIP] Wean off IOLoop.run_sync Wean off IOLoop.run_sync Mar 1, 2021
@dwoz dwoz marked this pull request as ready for review March 1, 2021 23:33
@Ch3LL Ch3LL added Test-Failure Fix the CI failure ⛈ has-failing-test and removed Test-Failure Fix the CI failure ⛈ labels Mar 2, 2021
@dwoz dwoz force-pushed the less_run_sync branch 2 times, most recently from c81c7ea to beefed7 Compare March 2, 2021 16:38
@Ch3LL Ch3LL merged commit 4cf62fb into saltstack:master Mar 4, 2021
@tsaridas tsaridas mentioned this pull request May 2, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Aluminium Release Post Mg and Pre Si
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants