Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to pkg beacon, fire when installed or removed #59463

Merged
merged 8 commits into from Feb 16, 2021

Conversation

garethgreenaway
Copy link
Member

@garethgreenaway garethgreenaway commented Feb 9, 2021

What does this PR do?

Updating the pkg beacon to fire the events when there are upgrades to packages, but also when watched packages are installed or removed. Breaking out the logic for listing pkgs from context into a separate function to aid in testing. Updating tests to ensure context is not used when use_context option to list_pkgs is False.

saltstack/salt-enhancement-proposals#39

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes/No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

… packages, but also when watched packages are installed or removed. Breaking out the logic for listing pkgs from context into a separate function to aid in testing. Updating tests to ensure context is not used when use_context option to list_pkgs is False. saltstack/salt-enhancement-proposals#39
@garethgreenaway garethgreenaway requested a review from a team as a code owner February 9, 2021 19:55
@garethgreenaway garethgreenaway requested review from Akm0d and Ch3LL and removed request for a team February 9, 2021 19:55
@garethgreenaway garethgreenaway added the Aluminium Release Post Mg and Pre Si label Feb 9, 2021
@garethgreenaway garethgreenaway removed the request for review from Akm0d February 9, 2021 19:56
@Ch3LL
Copy link
Contributor

Ch3LL commented Feb 10, 2021

Is this the same as this? #59316 but the tests do not seem to be migrated to pytest.

@garethgreenaway
Copy link
Member Author

@Ch3LL Yes. The previous PR got lost in merge-conflict nonsense and now looks like I missed some files.

@Ch3LL Ch3LL added the merge-conflict PR has a merge conflict label Feb 11, 2021
@garethgreenaway garethgreenaway removed the merge-conflict PR has a merge conflict label Feb 11, 2021
tests/pytests/unit/modules/test_aptpkg.py Outdated Show resolved Hide resolved
tests/pytests/unit/modules/test_yumpkg.py Outdated Show resolved Hide resolved
@Ch3LL Ch3LL merged commit 8ebc975 into saltstack:master Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Aluminium Release Post Mg and Pre Si
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants