Netbox pillar enhancements - Virtual Machines, Interfaces, IP Addresses, Documentation

[ggiesen]

What does this PR do?

What issues does this PR fix or reference?

Fixes: #51490
Fixes: #59398

Previous Behavior

The Netbox pillar doesn't currently support displaying any information for virtual machines at all, or displaying interface and IP information

New Behavior

Set:

ext_pillar:
  - netbox:
      api_url: https://netbox.example.com/api/
      api_token: XXX
      devices: True
      virtual_machines: True
      interfaces: True
      interface_ips: True

Example output

host.example.com:
    ----------
    netbox:
        ----------
        interfaces:
            |_
              ----------
              cable:
                  None
              cable_peer:
                  None
              cable_peer_type:
                  None
              connected_endpoint:
                  None
              connected_endpoint_reachable:
                  None
              connected_endpoint_type:
                  None
              count_ipaddresses:
                  0
              description:
              enabled:
                  True
              id:
                  7453
              ip_addresses:
              label:
              lag:
                  None
              mac_address:
                  None
              mgmt_only:
                  False
              mode:
                  None
              mtu:
                  None
              name:
                  GigabitEthernet0/0
              tagged_vlans:
              tags:
              type:
                  ----------
                  label:
                      1000BASE-T (1GE)
                  value:
                      1000base-t
              untagged_vlan:
                  None
              url:
                  https://netbox.example.com/api/dcim/interfaces/7453/
            |_
              ----------
              cable:
                  None
              cable_peer:
                  None
              cable_peer_type:
                  None
              connected_endpoint:
                  None
              connected_endpoint_reachable:
                  None
              connected_endpoint_type:
                  None
              count_ipaddresses:
                  0
              description:
              enabled:
                  True
              id:
                  7454
              ip_addresses:
              label:
              lag:
                  None
              mac_address:
                  None
              mgmt_only:
                  False
              mode:
                  None
              mtu:
                  None
              name:
                  GigabitEthernet0/1
              tagged_vlans:
              tags:
              type:
                  ----------
                  label:
                      1000BASE-T (1GE)
                  value:
                      1000base-t
              untagged_vlan:
                  None
              url:
                  https://netbox.example.com/api/dcim/interfaces/7454/
            |_
              ----------
              cable:
                  None
              cable_peer:
                  None
              cable_peer_type:
                  None
              connected_endpoint:
                  None
              connected_endpoint_reachable:
                  None
              connected_endpoint_type:
                  None
              count_ipaddresses:
                  1
              description:
              enabled:
                  True
              id:
                  7455
              ip_addresses:
                  |_
                    ----------
                    address:
                        192.0.2.87/32
                    created:
                        2021-02-12
                    description:
                    dns_name:
                    family:
                        ----------
                        label:
                            IPv4
                        value:
                            4
                    id:
                        1113
                    last_updated:
                        2021-02-12T15:05:04.456156Z
                    nat_inside:
                        None
                    nat_outside:
                        None
                    role:
                        ----------
                        label:
                            Loopback
                        value:
                            loopback
                    status:
                        ----------
                        label:
                            Active
                        value:
                            active
                    tags:
                    tenant:
                        None
                    url:
                        https://netbox.example.com/api/ipam/ip-addresses/1113/
                    vrf:
                        ----------
                        display_name:
                            EXAMPLE (64512:23456)
                        id:
                            2
                        name:
                            EXAMPLE
                        rd:
                            64512:23456
                        url:
                            https://netbox.example.com/api/ipam/vrfs/2/
        node_type:
            device

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

• Docs
• Changelog - https://docs.saltstack.com/en/master/topics/development/changelog.html
• Tests written/updated

Commits signed with GPG?

Yes/No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

[welcome]

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

• Community Wiki
• Salt’s Contributor Guide
• Join our Community Slack
• IRC on Freenode
• SaltStack YouTube channel
• SaltStackInc Twitch channel

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at core@saltstack.com. We’re glad you’ve joined our community and look forward to doing awesome things with you!

[ggiesen]

I'll work with @waynew during a test clinic to get tests implemented

[ggiesen]

re-run pr-macosxcatalina-py3-pytest

[ggiesen]

re-run pr-freebsd-130-amd64-py3-pytest

[Ch3LL]

bump @dwoz can you re-review here please