Skip to content

The salt-run CLI now accepts --jid which allows scripting against it #59523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2021
Merged

The salt-run CLI now accepts --jid which allows scripting against it #59523

merged 1 commit into from
Feb 18, 2021

Conversation

s0undt3ch
Copy link
Collaborator

What does this PR do?

See title.

This helps with proper testing under PyTest

@s0undt3ch s0undt3ch requested a review from krionbsd February 17, 2021 11:23
@s0undt3ch s0undt3ch requested a review from a team as a code owner February 17, 2021 11:23
krionbsd
krionbsd previously approved these changes Feb 17, 2021
View reviewed changes
Ch3LL
Ch3LL suggested changes Feb 17, 2021
View reviewed changes
@s0undt3ch
Copy link
Collaborator Author

These windows test failure are now a know issue and unrelated to the changes to this PR as seen in #59530.
It's being tracked in #59531

@krionbsd krionbsd self-requested a review February 18, 2021 07:48
twangboy
twangboy approved these changes Feb 18, 2021
View reviewed changes
Copy link
Contributor

@twangboy twangboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still failing tests on Windows

@Ch3LL Ch3LL merged commit ad4c3a5 into saltstack:master Feb 18, 2021
@s0undt3ch s0undt3ch deleted the hotfix/salt-run-jid branch February 18, 2021 14:28
@s0undt3ch
Copy link
Collaborator Author

@twangboy, yes, see #59530 and #59531

@sagetherage sagetherage added the Aluminium Release Post Mg and Pre Si label Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ch3LL Ch3LL Ch3LL approved these changes

@twangboy twangboy twangboy approved these changes

@krionbsd krionbsd krionbsd approved these changes

Assignees
No one assigned
Labels
Aluminium Release Post Mg and Pre Si
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@s0undt3ch @Ch3LL @twangboy @krionbsd @sagetherage