Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a new mod_beacon function to pkg, service, and file state modules #59559

Merged
merged 10 commits into from Feb 26, 2021

Conversation

garethgreenaway
Copy link
Contributor

@garethgreenaway garethgreenaway commented Feb 19, 2021

What does this PR do?

Adding mod_beacon function to pkg, service, and file state modules. This function will act similar to the mod_watch function. This will allow supported functions in those state modules to automatically add associated beacons to monitor for changes to the respective resources in the state file and fire events to the event bus when changes occur.

What issues does this PR fix or reference?

Fixes: N/A

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@garethgreenaway garethgreenaway requested a review from a team as a code owner February 19, 2021 19:04
@garethgreenaway garethgreenaway changed the title Adding a new mod_beacon to pkg, service, and file state modules Adding a new mod_beacon function to pkg, service, and file state modules Feb 19, 2021
…on.present state module rather that salt module.
…t function where the error occured. Fixing the comparision when adding beacons, ensuring we are not relying on the order in the list. Adding a pytest test for mod_beacon in file state module.
…ility to override defaults with beacon_data kwarg. Adding and updating tests.
@garethgreenaway garethgreenaway added the Aluminium Release Post Mg and Pre Si label Feb 22, 2021
salt/states/file.py Outdated Show resolved Hide resolved
salt/states/pkg.py Outdated Show resolved Hide resolved
salt/states/service.py Outdated Show resolved Hide resolved
@Ch3LL Ch3LL merged commit a423efb into saltstack:master Feb 26, 2021
@max-arnold
Copy link
Contributor

I belive this is a copy-paste induced error (both attributes reference the same emitatstartup key):

            data["emitatstartup"] = _beacon_data.get("emitatstartup", False)
            data["uncleanshutdown"] = _beacon_data.get("emitatstartup", None)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Aluminium Release Post Mg and Pre Si
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants