Adding a new mod_beacon function to pkg, service, and file state modules #59559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garethgreenaway
changed the title
…on.present state module rather that salt module.
…t function where the error occured. Fixing the comparision when adding beacons, ensuring we are not relying on the order in the list. Adding a pytest test for mod_beacon in file state module.
…con. Adding tests for pkg and service.
…ility to override defaults with beacon_data kwarg. Adding and updating tests.
garethgreenaway
force-pushed
the
state_system_add_beacons_new
branch
from
b34ad1c to
49b4d9a
Compare
Ch3LL
suggested changes
Feb 24, 2021
Ch3LL
approved these changes
Feb 25, 2021
Contributor
|
I belive this is a copy-paste induced error (both attributes reference the same |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adding mod_beacon function to pkg, service, and file state modules. This function will act similar to the mod_watch function. This will allow supported functions in those state modules to automatically add associated beacons to monitor for changes to the respective resources in the state file and fire events to the event bus when changes occur.
What issues does this PR fix or reference?
Fixes: N/A
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.