All matcher match functions must now accept a minion_id keyword arg
#59717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krionbsd
previously approved these changes
Mar 5, 2021
Since we're only doing a mapping, redoing the mapping for every test is not that expensive.
krionbsd
approved these changes
Mar 5, 2021
Ch3LL
requested changes
Mar 5, 2021
s0undt3ch
added a commit
to s0undt3ch/salt
that referenced
this pull request
Mar 5, 2021
See saltstack#59717 (comment) for more info
Merged
Ch3LL
pushed a commit
that referenced
this pull request
Mar 5, 2021
See #59717 (comment) for more info
|
Can I just check this doesn't apply to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
See title
What issues does this PR fix or reference?
Refs: #59603