Include Parrot in grains _OS_Family_Map

[unman]

What does this PR do?

Adds Parrot to OS_Family_Map in grains

What issues does this PR fix or reference?

Fixes: #60249

Previous Behavior

Could not use modules that referenced family

New Behavior

Fixed

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

• Docs
• Changelog - https://docs.saltstack.com/en/master/topics/development/changelog.html
• Tests written/updated

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

[welcome]

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

• Community Wiki
• Salt’s Contributor Guide
• Join our Community Slack
• IRC on Freenode
• Salt Project YouTube channel
• Salt Project Twitch channel

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at saltproject@vmware.com. We’re glad you’ve joined our community and look forward to doing awesome things with you!

[evelikov]

Parrot has a good os-release file so this PR will be effectively superseded by my PR - parse os-release ID_LIKE token #60171. That is assuming upstream is happy to merge it :-)

[unman]

On Tue, Jun 01, 2021 at 03:30:34AM -0700, Emil Velikov wrote: Parrot has a good [os-release file](https://github.com/ParrotSec/base-files/blob/master/etc/os-release) so this PR will be effectively superseded by my PR - parse os-release ID_LIKE token #60171. That is assuming upstream is happy to merge it :-)

Nice. But yours is more substantive, and parses an optional field, and mine is trivial.

[evelikov]

Indeed, stacking workarounds tends to be easier than fixing things properly.

[sagetherage]

@evelikov can you please add a changelog file for this additional Debian-based OS?

[unman]

On Tue, Jun 01, 2021 at 09:19:49AM -0700, Emil Velikov wrote: Indeed, stacking workarounds tends to be easier than fixing things properly.

It's not a workaround. It is the current tested mechanism. I have no idea how widespread "decent" os-release files are: nor do you.

[Ch3LL]

Can we also get a test added similar to https://github.com/saltstack/salt/pull/59177/files#diff-a31d52f107f2aba1214af30f17846b083d8a8ef58c4cdc76ae889f716a8df1a0R681

[garethgreenaway]

@unman Let us know if you need help writing a test for the change.

[unman]

Can we also get a test added similar to https://github.com/saltstack/salt/pull/59177/files#diff-a31d52f107f2aba1214af30f17846b083d8a8ef58c4cdc76ae889f716a8df1a0R681

Added a test (after the typo fixed) - good for you @Ch3LL ?

[Ch3LL]

@unman looks like there are some test failures that need to be cleaned up and a merge conflict. Also thanks for adding the test :)

[unman]

On Thu, Jul 29, 2021 at 09:48:35AM -0700, Megan Wilhite wrote: @unman looks like there are some test failures that need to be cleaned up and a merge conflict. Also thanks for adding the test :)

I'll take a look

[Ch3LL]

looks like there are just some test failures that need to be cleaned up here.

[Ch3LL]

bump ^

[Ch3LL]

@unman are willing to come back to this PR and fix up the tests?

[unman]

Thanks for the reminder.

[welcome]

Congratulations on your first PR being merged! 🎉