Update pcs support for > 0.10 #60257
Wayne Gemmell and others added 6 commits
May 26, 2021 16:58
On Tue, 24 Aug 2021, 20:04 welcome[bot], ***@***.***> wrote: Congratulations on your first PR being merged! 🎉 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#60257 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFORIRJCHCWBHRX7NSDTALT6PNK3ANCNFSM45RVTNKQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email> .
dwoz pushed a commit to dwoz/salt that referenced this pull request
Sep 12, 2021
* PCS module and state updated to handle pcs version > 0.10 * PCS module and state updated to handle pcs version > 0.10 - changelog * Removed six * Module documentation updated * Requested changes implemented * Add pcs module tests * Tests added and is_auth altered to fit purpose * Tests added. Debian bypass for broken config creation bypassed. * Tests debug output removed * Minor linting fixes * Update salt/modules/pcs.py Co-authored-by: Megan Wilhite <email@example.com> * Updated as per @Ch3LL's recommendations and other pre-commit fails * Removed test_config_show and some commented out print lines * Extra documentation added to cluster_setup * Updated item_show to work properly with properties and updated tests to match * Fixed change requests and added a wipe_default flag to remove default config * Extra args now gets passed from the pcs state to the auth function in the pcs module. * Minor formatting fix * Minor build fix to make linter happy Co-authored-by: Wayne Gemmell <firstname.lastname@example.org> Co-authored-by: Megan Wilhite <email@example.com> Co-authored-by: Sage the Rage <firstname.lastname@example.org>
new functionality including changes to functionality and code refactors, etc.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.