Implementation of held/unheld functions for state pkg#60432
Merged
Ch3LL merged 6 commits intosaltstack:masterfrom Jun 2, 2022
Merged
Implementation of held/unheld functions for state pkg#60432Ch3LL merged 6 commits intosaltstack:masterfrom
Ch3LL merged 6 commits intosaltstack:masterfrom
Conversation
vzhestkov
force-pushed
the
held-unheld-implementation
branch
from
cc0d23c to
1208cac
Compare
vzhestkov
force-pushed
the
held-unheld-implementation
branch
from
8bf386c to
968b304
Compare
Ch3LL
suggested changes
Jun 29, 2021
Contributor
Ch3LL
left a comment
Ch3LL
left a comment
There was a problem hiding this comment.
this will require a changelog and test coverage
vzhestkov
force-pushed
the
held-unheld-implementation
branch
from
ca38197 to
2ea5f00
Compare
Ch3LL
suggested changes
Aug 9, 2021
twangboy
requested changes
May 2, 2022
Contributor
|
@vzhestkov Some merge conflicts on this one and some requested changes. |
vzhestkov
force-pushed
the
held-unheld-implementation
branch
2 times, most recently
from
dafb8ee to
353c119
Compare
Fix docs for held/unheld functions of pkg state Remove ignoring retcode 104 in favour for PR#58552 Add `root` parameter to hold/unhold functions Move `root` to functions signature and add missing parameter description to held/unheld Remove all_versions and ignore_no_matching_item Add root to hold/unhold docstrings Remove empty line
Add unit test for pkg.held/unheld state functions Code formatting fix for the tests Fix test formatting
vzhestkov
force-pushed
the
held-unheld-implementation
branch
from
353c119 to
51e2399
Compare
twangboy
requested changes
May 27, 2022
twangboy
approved these changes
May 27, 2022
Contributor
Author
|
@twangboy thanks a lot for taking care of it |
Ch3LL
approved these changes
May 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implements
held/unheldfunctions for statepkgmodule.Examples:
Implements
list_holdsfunction forzypperpkgmodule. The output is similar toyumpkg.list_holds. The only difference is thatzypperpkgcalculates the current locked packages fromlist_locksas the yum and zypper have different way of managing locks.Improves
holdfunction forzypperpkgto handle package version if specified.