-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT 60430: Add ability for wait_for_event to handle list event_id values #60443
Conversation
Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar. |
more pythonic if/then/else on list Co-authored-by: Pedro Algarvio <pedro@algarvio.me>
@krionbsd sorry I haven't come back and checked on this, out on paternity :) Could someone have a look at this? Let me know if there are any blockers to merging. |
@krionbsd @s0undt3ch Sorry for the very late follow up on this...I got back from paternity leave not long ago, I believe this is still a valid MR. Is this still something I could get merged? You both have approved but I can't click the merge button. Thanks! |
Congratulations on your first PR being merged! 🎉 |
What does this PR do?
Adds support for comparing
id_list
with a list when the value forevent_id
is a list in thesalt.wait_for_event
module.What issues does this PR fix or reference?
Fixes #60430
Previous Behavior
Previously,
salt.wait_for_event
only supportedevent_id
values that wherestr
.New Behavior
In addition to the previous behavior, now supports
event_id
values that are lists.Given the event:
the following
salt.wait_for_event
would not work peviously:This PR checks if the
val
returned by theevent_id
location in the event is a list and if so, pops off any values fromid_list
that it finds inval
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
event_id
so I did not updateCommits signed with GPG?
No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.