Ignore configuration for 'enable_fqdns_grains' for AIX, Solaris and Juniper#60533
Merged
garethgreenaway merged 13 commits intosaltstack:masterfrom Jul 21, 2021
Merged
Conversation
Ch3LL
previously approved these changes
Jul 13, 2021
dmurphy18
force-pushed
the
fqdns_grains_ignore_60529
branch
2 times, most recently
from
478c4f0 to
4988572
Compare
Contributor
|
ping @dmurphy18 there is a merge conflict. |
Contributor
Author
|
yup, that is why I didn't update to latest master. Want to get the Windows failure resolved first before moving on to the merge issue. Will resolve the merge issue once the Windows failure is resolved. |
added 13 commits
July 20, 2021 17:50
…est_bsd on windows
dmurphy18
force-pushed
the
fqdns_grains_ignore_60529
branch
from
5cd8477 to
37bce17
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Ignore configuration for 'enable_fqdns_grains' for AIX, Solaris and Juniper
What issues does this PR fix or reference?
Fixes: #60529
Previous Behavior
'enable_fqdns_grains' default value of True was causing issues porting Salt 3003.1 (Seq Fault - Core), fixed with a patch file.
New Behavior
Ignore 'enable_fqdns_grains' setting similar to existing Windows and Proxy checks, for AIX, Solaris and Junos (Juniper) where checking for fqdns has or will cause issues, for example: reverse DNS lookup on a Juniper router will be problematic (current native minion ships with setting defaulted to False). This change alieves this.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.