Fix #59033: salt-ssh error when targetting IPs or hostnames directly #60729
Conversation
|
Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar. |
javicacheiro
force-pushed
the
fix_salt-ssh_targetting_ips
branch
from
90ef3b1 to
c80f6cb
Compare
javicacheiro
changed the title
Ch3LL
force-pushed
the
fix_salt-ssh_targetting_ips
branch
from
1880a39 to
15c170a
Compare
|
@javicacheiro can you remove this PR from draft status |
|
Done! |
| try: | ||
| roster_host = roster_data[host_id].get("host") | ||
| except AttributeError: | ||
| roster_host = roster_data[host_id] | ||
| if hostname in [host_id, roster_host]: |
There was a problem hiding this comment.
suggestion(non-blocking) this could be written as if hostname in [host_id, roster_data.get(host_id, {}).get("host")]:
Not sure if that's easier to read or not 🤷
There was a problem hiding this comment.
well, this does fail with the existing test suite, so maybe not :)
|
Congratulations on your first PR being merged! 🎉 |
What does this PR do?
Fixes salt-ssh error when targetting IPs or hostnames directly
What issues does this PR fix or reference?
Fixes: #59033
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
No