Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VMware expanded virtual hardware features #60739

Conversation

ggiesen
Copy link
Contributor

@ggiesen ggiesen commented Aug 15, 2021

What does this PR do?

What issues does this PR fix or reference?

Fixes: #56144

New Behavior

Expands the VMware cloud provider to permit CPU and memory hot-add as well as nested virtualization. Based on @nicholasmhughes PR in #56173

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

No

@ggiesen ggiesen requested a review from a team as a code owner August 15, 2021 12:29
@ggiesen ggiesen requested review from krionbsd and removed request for a team August 15, 2021 12:29
@ggiesen ggiesen changed the title WIP: VMware expanded virtual hardware features VMware expanded virtual hardware features Nov 21, 2021
@github-actions
Copy link

Hi! I'm your friendly PR bot!

You might be wondering what I'm doing commenting here on your PR.

Yes, as a matter of fact, I am...

I'm just here to help us improve the documentation. I can't respond to
questions or anything, but what I can do, I do well!

Okay... so what do you do?

I detect modules that are missing docstrings or "CLI Example" on existing docstrings!
When I was created we had a lot of these. The documentation for these
modules need some love and attention to make Salt better for our users.

So what does that have to do with my PR?

I noticed that in this PR there are some files changed that have some of these
issues. So I'm leaving this comment to let you know your options.

Okay, what are they?

Well, my favorite, is that since you were making changes here I'm hoping that
you would be the most familiar with this module and be able to add some other
examples or fix any of the reported issues.

If I can, then what?

Well, you can either add them to this PR or add them to another PR. Either way is fine!

Well... what if I can't, or don't want to?

That's also fine! We appreciate all contributions to the Salt Project. If you
can't add those other examples, either because you're too busy, or unfamiliar,
or you just aren't interested, we still appreciate the contributions that
you've made already.

Whatever approach you decide to take, just drop a comment here letting us know!

Detected Issues (click me)
[INFO] Initializing environment for https://github.com/saltstack/pip-tools-compile-impersonate.
[INFO] Initializing environment for https://github.com/asottile/pyupgrade.
[INFO] Initializing environment for https://github.com/saltstack/pre-commit-remove-import-headers.
[INFO] Initializing environment for https://github.com/s0undt3ch/salt-rewrite.
[INFO] Initializing environment for https://github.com/timothycrosley/isort.
[INFO] Initializing environment for https://github.com/timothycrosley/isort:toml.
[INFO] Initializing environment for https://github.com/psf/black.
[INFO] Initializing environment for https://github.com/asottile/blacken-docs.
[INFO] Initializing environment for https://github.com/asottile/blacken-docs:black==21.7b0.
[INFO] Initializing environment for https://github.com/PyCQA/bandit.
[INFO] Initializing environment for https://github.com/saltstack/invoke-pre-commit.
[INFO] Initializing environment for https://github.com/saltstack/invoke-pre-commit:blessings,distro,jinja2,msgpack,pyyaml.
[INFO] Initializing environment for https://github.com/saltstack/mirrors-nox.
[INFO] Initializing environment for https://github.com/saltstack/mirrors-nox:pip>=20.2.4,<21.2,setuptools<58.0.
[INFO] Installing environment for https://github.com/saltstack/invoke-pre-commit.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
Check Known Missing Docstrings...........................................Passed
- hook id: invoke
- duration: 1.01s

Thanks again!

@Ch3LL Ch3LL added the Phosphorus v3005.0 Release code name and version label Jan 20, 2022
@garethgreenaway garethgreenaway merged commit 9b1b791 into saltstack:master Jan 20, 2022
garethgreenaway pushed a commit to bryceml/salt that referenced this pull request Jan 21, 2022
* fixes saltstack#56144 to enable hotadd profile support

* updates for black

* complying with new tests that were recently added

* Add suppor for cpuHotRemoveEnabled, nestedHVEnabled, vPMCEnabled

* Update docs for cpuHotRemoveEnabled, nestedHVEnabled, vPMCEnabled

* Add checks for platform and primary_ip and print errors if they are missing when proxy_return is set

* Add changelog

* Add changelog

* Roll back commit and properly add files

* Revert "Roll back commit and properly add files"

This reverts commit 59fd715.

* Revert "Add changelog"

This reverts commit 036fc35.

* Revert "Add checks for platform and primary_ip and print errors if they are missing when proxy_return is set"

This reverts commit 090aa3a.

Co-authored-by: nicholasmhughes <nicholasmhughes@gmail.com>
Co-authored-by: Dmitry Kuzmenko <dmitry.kuzmenko@dsr-corporation.com>
Co-authored-by: Daniel Wozniak <dwozniak@saltstack.com>
Co-authored-by: Sage the Rage <36676171+sagetherage@users.noreply.github.com>
@ggiesen ggiesen deleted the vmware_expanded_virtual_hardware_features branch June 15, 2022 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Phosphorus v3005.0 Release code name and version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

salt-cloud - enable mem-hotadd to my salt cloud profile. Extra config array ignored
9 participants