-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VMware expanded virtual hardware features #60739
VMware expanded virtual hardware features #60739
Conversation
Update docs for cpuHotRemoveEnabled, nestedHVEnabled, vPMCEnabled
…issing when proxy_return is set
…m:ggiesen/salt into vmware_expanded_virtual_hardware_features Merge upstream changes
This reverts commit 59fd715.
…m:ggiesen/salt into vmware_expanded_virtual_hardware_features
This reverts commit 036fc35.
…ey are missing when proxy_return is set" This reverts commit 090aa3a.
Hi! I'm your friendly PR bot!You might be wondering what I'm doing commenting here on your PR. Yes, as a matter of fact, I am... I'm just here to help us improve the documentation. I can't respond to Okay... so what do you do? I detect modules that are missing docstrings or "CLI Example" on existing docstrings! So what does that have to do with my PR? I noticed that in this PR there are some files changed that have some of these Okay, what are they? Well, my favorite, is that since you were making changes here I'm hoping that If I can, then what? Well, you can either add them to this PR or add them to another PR. Either way is fine! Well... what if I can't, or don't want to? That's also fine! We appreciate all contributions to the Salt Project. If you Whatever approach you decide to take, just drop a comment here letting us know! Detected Issues (click me)[INFO] Initializing environment for https://github.com/saltstack/pip-tools-compile-impersonate. [INFO] Initializing environment for https://github.com/asottile/pyupgrade. [INFO] Initializing environment for https://github.com/saltstack/pre-commit-remove-import-headers. [INFO] Initializing environment for https://github.com/s0undt3ch/salt-rewrite. [INFO] Initializing environment for https://github.com/timothycrosley/isort. [INFO] Initializing environment for https://github.com/timothycrosley/isort:toml. [INFO] Initializing environment for https://github.com/psf/black. [INFO] Initializing environment for https://github.com/asottile/blacken-docs. [INFO] Initializing environment for https://github.com/asottile/blacken-docs:black==21.7b0. [INFO] Initializing environment for https://github.com/PyCQA/bandit. [INFO] Initializing environment for https://github.com/saltstack/invoke-pre-commit. [INFO] Initializing environment for https://github.com/saltstack/invoke-pre-commit:blessings,distro,jinja2,msgpack,pyyaml. [INFO] Initializing environment for https://github.com/saltstack/mirrors-nox. [INFO] Initializing environment for https://github.com/saltstack/mirrors-nox:pip>=20.2.4,<21.2,setuptools<58.0. [INFO] Installing environment for https://github.com/saltstack/invoke-pre-commit. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... Check Known Missing Docstrings...........................................Passed - hook id: invoke - duration: 1.01s Thanks again! |
* fixes saltstack#56144 to enable hotadd profile support * updates for black * complying with new tests that were recently added * Add suppor for cpuHotRemoveEnabled, nestedHVEnabled, vPMCEnabled * Update docs for cpuHotRemoveEnabled, nestedHVEnabled, vPMCEnabled * Add checks for platform and primary_ip and print errors if they are missing when proxy_return is set * Add changelog * Add changelog * Roll back commit and properly add files * Revert "Roll back commit and properly add files" This reverts commit 59fd715. * Revert "Add changelog" This reverts commit 036fc35. * Revert "Add checks for platform and primary_ip and print errors if they are missing when proxy_return is set" This reverts commit 090aa3a. Co-authored-by: nicholasmhughes <nicholasmhughes@gmail.com> Co-authored-by: Dmitry Kuzmenko <dmitry.kuzmenko@dsr-corporation.com> Co-authored-by: Daniel Wozniak <dwozniak@saltstack.com> Co-authored-by: Sage the Rage <36676171+sagetherage@users.noreply.github.com>
What does this PR do?
What issues does this PR fix or reference?
Fixes: #56144
New Behavior
Expands the VMware cloud provider to permit CPU and memory hot-add as well as nested virtualization. Based on @nicholasmhughes PR in #56173
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
No