Do not consider "skipped" targets as failed for "ansible.playbooks" states #60983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 1, 2021
garethgreenaway
approved these changes
Apr 20, 2022
twangboy
approved these changes
May 2, 2022
s0undt3ch
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes a misbehavior of
ansible.playbooksstates when some of the targets of the playbook are being "skipped".Currently, when there are "skipped" targets, then
ansible.playbooksstate execution will return failed. This seems wrong here since the "ansible-playbook" command called under the hood is actually not considering the execution as failed but succeeding and returning retcode 0.This PR simply fixed this misbehavior and make "ansible.playbooks" state to succeed even if there are "skipped" targets as Ansible does.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.