Make sys.argspec handle functions with annotations

[msteed]

What does this PR do?

Makes sys.argspec not die on functions that use annotations

What issues does this PR fix or reference?

Fixes: #48735

Previous Behavior

Calling sys.argspec on a salt function that used annotations failed with

ValueError: Function has keyword-only arguments or annotations, use getfullargspec() API which can support them

New Behavior

Calling sys.argspec on a salt function with annotations works (annotations are ignored)

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

• Docs
• Changelog - https://docs.saltproject.io/en/master/topics/development/changelog.html
• Tests written/updated

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

[msteed]

Might also fix #55499

[msteed]

@xeacott - can I get a review please?

[xeacott]

Lint failed for some reason on this... I'm not too familiar with the change itself however the code looks good, test looks good and changelog is there. If you feel that an integration test or another unit test would be helpful here, maybe to test a negative outcome or ensure that pytest doesn't raise a ValueError, that would be valuable.

[msteed]

@xeacott - I already added a test to cover the previously failing case. Is there something else I should be testing?

I know lint has passed on this PR before. I'll update from master and let it run again.

[xeacott]

@msteed Oh thought that test file was inside pytest. Would you be able to covert it? Previously that's been an ask for smaller files (to convert an older test file to pytest) from the core team.

[msteed]

Converted ✔️

[xeacott]

re-run full all

[msteed]

Failing checks seem unrelated to these changes (failing to create VMs)

[dmurphy18]

@msteed We are all waiting for the amazon and windows tests to work, SRE looking into it