-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Add support for get IP-address from agent #61146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
72c2fdc
to
69a57a6
Compare
Hi @scornelissen85, and thanks for your contribution. Would you be able to add a changelog entry and relevant tests? Also, requesting a review from @Ch3LL for a second opinion. |
c26d43a
to
2095c1e
Compare
@MKLeb I have added a test and added a changelog entry. |
477ac3e
to
1299586
Compare
1299586
to
414ae1d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a clarifying question
8ea076e
to
414ae1d
Compare
Hi! I'm your friendly PR bot!You might be wondering what I'm doing commenting here on your PR. Yes, as a matter of fact, I am... I'm just here to help us improve the documentation. I can't respond to Okay... so what do you do? I detect modules that are missing docstrings or "CLI Example" on existing docstrings! So what does that have to do with my PR? I noticed that in this PR there are some files changed that have some of these Okay, what are they? Well, my favorite, is that since you were making changes here I'm hoping that If I can, then what? Well, you can either add them to this PR or add them to another PR. Either way is fine! Well... what if I can't, or don't want to? That's also fine! We appreciate all contributions to the Salt Project. If you Whatever approach you decide to take, just drop a comment here letting us know! Detected Issues (click me)Check Known Missing Docstrings...........................................Failed - hook id: invoke - duration: 2.13s - exit code: 1 Thanks again! |
e928894
to
552478f
Compare
@Ch3LL I've added documentation in |
e88dbd1
to
fc88552
Compare
fc88552
to
ea6d20e
Compare
With this change it is possible again to use the qemu-agent of the VM to fetch the IP-address of it. The code already was in develop branch, I have migrate it back to the current master branch.
To use this option, set
agent_get_ip
in the cloud profile to1
(integer). When the VM boots and the agent is started it will fetch the IP-adress of the Qemu VM and use that IP for the next actions for Salt-cloud.