Skip to content

Add support for get IP-address from agent #61146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 1, 2022

Conversation

SndR85
Copy link
Contributor

@SndR85 SndR85 commented Oct 29, 2021

With this change it is possible again to use the qemu-agent of the VM to fetch the IP-address of it. The code already was in develop branch, I have migrate it back to the current master branch.

To use this option, set agent_get_ip in the cloud profile to 1 (integer). When the VM boots and the agent is started it will fetch the IP-adress of the Qemu VM and use that IP for the next actions for Salt-cloud.

@SndR85 SndR85 requested a review from a team as a code owner October 29, 2021 09:58
@SndR85 SndR85 requested review from MKLeb and removed request for a team October 29, 2021 09:58
@SndR85 SndR85 force-pushed the feature/proxmox-ip-by-agent branch 3 times, most recently from 72c2fdc to 69a57a6 Compare November 1, 2021 10:46
@MKLeb
Copy link
Contributor

MKLeb commented Nov 10, 2021

Hi @scornelissen85, and thanks for your contribution. Would you be able to add a changelog entry and relevant tests?

Also, requesting a review from @Ch3LL for a second opinion.

@MKLeb MKLeb requested a review from Ch3LL November 10, 2021 15:21
@SndR85 SndR85 force-pushed the feature/proxmox-ip-by-agent branch 7 times, most recently from c26d43a to 2095c1e Compare November 19, 2021 07:23
@SndR85
Copy link
Contributor Author

SndR85 commented Nov 19, 2021

@MKLeb I have added a test and added a changelog entry.

@SndR85 SndR85 force-pushed the feature/proxmox-ip-by-agent branch from 477ac3e to 1299586 Compare November 26, 2021 09:47
@SndR85 SndR85 force-pushed the feature/proxmox-ip-by-agent branch from 1299586 to 414ae1d Compare December 8, 2021 16:42
Copy link
Contributor

@Ch3LL Ch3LL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a clarifying question

@SndR85 SndR85 requested a review from s0undt3ch as a code owner January 20, 2022 09:12
@SndR85 SndR85 force-pushed the feature/proxmox-ip-by-agent branch from 8ea076e to 414ae1d Compare January 20, 2022 09:16
@github-actions
Copy link

Hi! I'm your friendly PR bot!

You might be wondering what I'm doing commenting here on your PR.

Yes, as a matter of fact, I am...

I'm just here to help us improve the documentation. I can't respond to
questions or anything, but what I can do, I do well!

Okay... so what do you do?

I detect modules that are missing docstrings or "CLI Example" on existing docstrings!
When I was created we had a lot of these. The documentation for these
modules need some love and attention to make Salt better for our users.

So what does that have to do with my PR?

I noticed that in this PR there are some files changed that have some of these
issues. So I'm leaving this comment to let you know your options.

Okay, what are they?

Well, my favorite, is that since you were making changes here I'm hoping that
you would be the most familiar with this module and be able to add some other
examples or fix any of the reported issues.

If I can, then what?

Well, you can either add them to this PR or add them to another PR. Either way is fine!

Well... what if I can't, or don't want to?

That's also fine! We appreciate all contributions to the Salt Project. If you
can't add those other examples, either because you're too busy, or unfamiliar,
or you just aren't interested, we still appreciate the contributions that
you've made already.

Whatever approach you decide to take, just drop a comment here letting us know!

Detected Issues (click me)
Check Known Missing Docstrings...........................................Failed
- hook id: invoke
- duration: 2.13s
- exit code: 1

The function 'recv' on 'salt/modules/cp.py' was previously known to not have a CLI Example, which is no longer the case. Please remove it from 'MISSING_EXAMPLES'. in 'tasks/docstrings.py'
The function 'recv_chunked' on 'salt/modules/cp.py' was previously known to not have a CLI Example, which is no longer the case. Please remove it from 'MISSING_EXAMPLES'. in 'tasks/docstrings.py'
The function 'envs' on 'salt/modules/cp.py' was previously known to not have a CLI Example, which is no longer the case. Please remove it from 'MISSING_EXAMPLES'. in 'tasks/docstrings.py'
The function 'to_salt_event' on 'salt/beacons/watchdog.py' does not have a docstring
The function 'close' on 'salt/beacons/watchdog.py' does not have a docstring
The function 'fqdns' on 'salt/modules/network.py' does not have a 'CLI Example:' in it's docstring
The function 'nesthash' on 'salt/modules/virt.py' does not have a 'CLI Example:' in it's docstring
The function 'init' on 'salt/modules/virt.py' does not have a 'CLI Example:' in it's docstring
The function 'node_devices' on 'salt/modules/virt.py' does not have a 'CLI Example:' in it's docstring
The function 'network_update' on 'salt/modules/virt.py' does not have a 'CLI Example:' in it's docstring
The function 'pool_update' on 'salt/modules/virt.py' does not have a 'CLI Example:' in it's docstring
The function 'avail_locations' on 'salt/cloud/clouds/hetzner.py' does not have a docstring
The function 'avail_images' on 'salt/cloud/clouds/hetzner.py' does not have a docstring
The function 'avail_sizes' on 'salt/cloud/clouds/hetzner.py' does not have a docstring
The function 'list_ssh_keys' on 'salt/cloud/clouds/hetzner.py' does not have a docstring
The function 'list_nodes_full' on 'salt/cloud/clouds/hetzner.py' does not have a docstring
The function 'list_nodes' on 'salt/cloud/clouds/hetzner.py' does not have a docstring
The function 'show_instance' on 'salt/cloud/clouds/hetzner.py' does not have a docstring
The function 'verify_logs_filter' on 'salt/utils/verify.py' does not have a docstring
The function 'close' on 'salt/beacons/inotify.py' does not have a docstring
The function 'create' on 'salt/modules/boto_elb.py' does not have a 'CLI Example:' in it's docstring
The function 'delete' on 'salt/modules/boto_elb.py' does not have a 'CLI Example:' in it's docstring
The function 'set_attributes' on 'salt/modules/boto_elb.py' does not have a 'CLI Example:' in it's docstring
The function 'set_health_check' on 'salt/modules/boto_elb.py' does not have a 'CLI Example:' in it's docstring
Found 3 warnings
Found 21 errors


Thanks again!

@SndR85 SndR85 force-pushed the feature/proxmox-ip-by-agent branch 2 times, most recently from e928894 to 552478f Compare January 20, 2022 09:27
@SndR85
Copy link
Contributor Author

SndR85 commented Jan 20, 2022

@Ch3LL I've added documentation in doc/topics/cloud/proxmox.rst

@SndR85 SndR85 force-pushed the feature/proxmox-ip-by-agent branch 3 times, most recently from e88dbd1 to fc88552 Compare January 20, 2022 11:32
@MKLeb MKLeb requested a review from Ch3LL January 20, 2022 17:48
MKLeb
MKLeb previously approved these changes Jan 20, 2022
@Ch3LL Ch3LL added the Phosphorus v3005.0 Release code name and version label Jan 21, 2022
@Ch3LL Ch3LL merged commit 31b5d6f into saltstack:master Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Phosphorus v3005.0 Release code name and version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants