Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add event return capability to Splunk returner #61150

Merged
merged 6 commits into from
Feb 7, 2022

Conversation

mymindstorm
Copy link
Contributor

@mymindstorm mymindstorm commented Oct 29, 2021

What does this PR do?

Adds event_returner support to Splunk returner.

I've tested this patch against my company's Splunk environment.

What issues does this PR fix or reference?

References: #50815

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

@mymindstorm mymindstorm requested a review from a team as a code owner October 29, 2021 17:02
@mymindstorm mymindstorm requested review from dhiltonp and removed request for a team October 29, 2021 17:02
@mymindstorm
Copy link
Contributor Author

mymindstorm commented Nov 21, 2021

@dhiltonp is there anything I can do to help get this PR reviewed?

salt/returners/splunk.py Outdated Show resolved Hide resolved
@github-actions
Copy link

Hi! I'm your friendly PR bot!

You might be wondering what I'm doing commenting here on your PR.

Yes, as a matter of fact, I am...

I'm just here to help us improve the documentation. I can't respond to
questions or anything, but what I can do, I do well!

Okay... so what do you do?

I detect modules that are missing docstrings or "CLI Example" on existing docstrings!
When I was created we had a lot of these. The documentation for these
modules need some love and attention to make Salt better for our users.

So what does that have to do with my PR?

I noticed that in this PR there are some files changed that have some of these
issues. So I'm leaving this comment to let you know your options.

Okay, what are they?

Well, my favorite, is that since you were making changes here I'm hoping that
you would be the most familiar with this module and be able to add some other
examples or fix any of the reported issues.

If I can, then what?

Well, you can either add them to this PR or add them to another PR. Either way is fine!

Well... what if I can't, or don't want to?

That's also fine! We appreciate all contributions to the Salt Project. If you
can't add those other examples, either because you're too busy, or unfamiliar,
or you just aren't interested, we still appreciate the contributions that
you've made already.

Whatever approach you decide to take, just drop a comment here letting us know!

Detected Issues (click me)
[INFO] Initializing environment for https://github.com/saltstack/pip-tools-compile-impersonate.
[INFO] Initializing environment for https://github.com/asottile/pyupgrade.
[INFO] Initializing environment for https://github.com/saltstack/pre-commit-remove-import-headers.
[INFO] Initializing environment for https://github.com/s0undt3ch/salt-rewrite.
[INFO] Initializing environment for https://github.com/timothycrosley/isort.
[INFO] Initializing environment for https://github.com/timothycrosley/isort:toml.
[INFO] Initializing environment for https://github.com/psf/black.
[INFO] Initializing environment for https://github.com/asottile/blacken-docs.
[INFO] Initializing environment for https://github.com/asottile/blacken-docs:black==21.7b0.
[INFO] Initializing environment for https://github.com/PyCQA/bandit.
[INFO] Initializing environment for https://github.com/saltstack/invoke-pre-commit.
[INFO] Initializing environment for https://github.com/saltstack/invoke-pre-commit:blessings,distro,jinja2,msgpack,pyyaml.
[INFO] Initializing environment for https://github.com/saltstack/mirrors-nox.
[INFO] Initializing environment for https://github.com/saltstack/mirrors-nox:pip>=20.2.4,<21.2,setuptools<58.0.
[INFO] Installing environment for https://github.com/saltstack/invoke-pre-commit.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
Check Known Missing Docstrings...........................................Passed
- hook id: invoke
- duration: 1.08s

Thanks again!

@dhiltonp
Copy link
Contributor

re-run pr-fedora-35-x86_64-py3-pytest

@dhiltonp
Copy link
Contributor

dhiltonp commented Dec 1, 2021

@s0undt3ch I've re-run the failing test 2 or 3 times, do you have an idea what's up with it?

@mymindstorm
Copy link
Contributor Author

mymindstorm commented Jan 18, 2022

re-run pr-centos-7-x86_64-py3-m2crypto-pytest
re-run pr-arch-lts-x86_64-py3-pytest
re-run pr-amazon-2-x86_64-py3-pytest
re-run pr-alma-8-x86_64-py3-pytest

@mymindstorm
Copy link
Contributor Author

mymindstorm commented Jan 18, 2022

I updated the branch and some of the CI seems to be failing due to some problem communicating with AWS. Re-running...

@mymindstorm
Copy link
Contributor Author

@dhiltonp the CI issues with this PR appear to be resolved.

@dhiltonp dhiltonp merged commit a575896 into saltstack:master Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants